Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482388 - =app-emulation/open-vm-tools-kmod-2013.04.16.1098359 with kernel 3.10.* - modules/linux/vmhgfs/file.c:754:32: error: dereferencing pointer to incomplete type
Summary: =app-emulation/open-vm-tools-kmod-2013.04.16.1098359 with kernel 3.10.* - mod...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords:
: 482586 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-25 05:54 UTC by Mark R. Pariente
Modified: 2013-10-19 21:16 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,83.34 KB, text/x-log)
2013-08-25 05:54 UTC, Mark R. Pariente
Details
patch for vmhgfs (1098359-vmhgfs-3.10.0.patch,396 bytes, patch)
2013-09-09 12:12 UTC, Andreas Fragner
Details | Diff
patch for vmsync (1098359-vmsync-3.10.0.patch,1.09 KB, patch)
2013-09-09 12:13 UTC, Andreas Fragner
Details | Diff
open-vm-tools-kmod-2013.04.16.1098359.ebuild (open-vm-tools-kmod-2013.04.16.1098359.ebuild,2.02 KB, text/plain)
2013-09-21 19:23 UTC, Billy DeVincentis
Details
vmblock.3.11 patch (1098359-vmblock.3.11.patch,2.35 KB, patch)
2013-09-21 19:24 UTC, Billy DeVincentis
Details | Diff
New ebuild (open-vm-tools-kmod-2013.09.16.1328054.ebuild,2.06 KB, text/plain)
2013-10-18 19:41 UTC, Brandon Holbrook
Details
open-vm-tools-kmod-2013.09.16.1328054.ebuild (open-vm-tools-kmod-2013.09.16.1328054.ebuild,2.06 KB, text/plain)
2013-10-18 19:42 UTC, Brandon Holbrook
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark R. Pariente 2013-08-25 05:54:14 UTC
Trying to emerge app-emulation/open-vm-tools-kmod-2013.04.16.1098359 against sys-kernel/gentoo-sources-3.10.9 results in build errors. Full build log attached.

Reproducible: Always
Comment 1 Mark R. Pariente 2013-08-25 05:54:50 UTC
Created attachment 356944 [details]
Build log
Comment 2 Mike Gilbert gentoo-dev 2013-08-25 15:26:48 UTC
Yeah, I spent some time trying to make it work with 3.10.9 yesterday. Everything except the vmxnet driver fails for me for one reason or another.

If you have a patch, I'll check it out, but I was really just going to wait for upstream to do another release at this point.
Comment 3 Mark R. Pariente 2013-08-25 19:44:30 UTC
I'll give patching a shot. In the meanwhile, perhaps it might be prudent to add a blocker for kernel version >=3.10.9 ? Actually I'm not even sure if this is the first kernel version to exhibit this issue, on my VM I upgraded straight from 3.9.x to 3.10.9. I can do some testing to figure out where the breakage started.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2013-08-27 15:33:38 UTC
*** Bug 482586 has been marked as a duplicate of this bug. ***
Comment 5 Amir Aupov 2013-08-31 14:46:41 UTC
I can confirm that 3.10.0 is affected too.
Comment 6 Andreas Fragner 2013-09-09 12:12:07 UTC
Same Problem here with hardened-sources which are now 3.10.1-r1 stable for AMD64. I spent some time with google and found on this page a complete patchset to get open-vm-tools-kmod working with 3.10 kernel. 
I extracted the relevant parts and created two patches for my own ebuild to test if it works - yes it does.

Attached find the 2 patches for adding this to the current ebuild.

You also have to include the patches in the ebuild file:

Here is the complete epatch part from the ebuild:

	epatch "${FILESDIR}/frozen.patch"
	epatch "${FILESDIR}/putname.patch"
	epatch "${FILESDIR}/1098359-vmblock-3.10.0.patch"
	epatch "${FILESDIR}/1098359-vmhgfs-3.10.0.patch"
	epatch "${FILESDIR}/1098359-vmsync-3.10.0.patch"
	epatch_user
Comment 7 Andreas Fragner 2013-09-09 12:12:52 UTC
Created attachment 358364 [details, diff]
patch for vmhgfs
Comment 8 Andreas Fragner 2013-09-09 12:13:14 UTC
Created attachment 358366 [details, diff]
patch for vmsync
Comment 9 Mike Gilbert gentoo-dev 2013-09-09 14:09:28 UTC
(In reply to Andreas Fragner from comment #6)

Where did these patches come from?
Comment 10 Daniel 2013-09-12 08:18:18 UTC
It would also be great to follow the upstream packages and disable VMCI and VMSOCK for kernels >= 3.9

see http://sourceforge.net/p/open-vm-tools/mailman/open-vm-tools-announce/?viewmonth=201304
Comment 11 Tomáš Mózes 2013-09-12 09:34:24 UTC
With the patches provided by Andreas, I could compile open-vm-tools-kmod on 3.10.10-hardened. However, loading vmhgfs.ko emits:

vmhgfs: Unknown symbol VMCIDatagram_Send (err 0)
vmhgfs: Unknown symbol VMCIDatagram_DestroyHnd (err 0)
vmhgfs: Unknown symbol VMCIDatagram_CreateHnd (err 0)

vmblock and vmsync seems to modprobe ok. As noted by Daniel, vmci and vsock should be removed from the list, because it's already in the kernel.
Comment 12 Billy DeVincentis 2013-09-21 19:22:14 UTC
Just wanted to add some things here
I wanted to get this building on 3.11
here is a working ebuild and the needed 3.11 vmblock patch
Comment 13 Billy DeVincentis 2013-09-21 19:23:41 UTC
Created attachment 359200 [details]
open-vm-tools-kmod-2013.04.16.1098359.ebuild
Comment 14 Billy DeVincentis 2013-09-21 19:24:27 UTC
Created attachment 359202 [details, diff]
vmblock.3.11 patch
Comment 15 Billy DeVincentis 2013-09-21 19:25:15 UTC
hgfs simply doesn't work on 3.11 so it is simply disabled in  the ebuild
Comment 16 Brandon Holbrook 2013-10-18 19:40:49 UTC
Upstream has released a new snapshot version 2013.09.16, but it doesn't seem to have fixed these compile issues, so the patches are still needed.

I've gone ahead and created an ebuild for the new version that incorporates these patches as well as disables building vmhgfs on 3.10+ and vmci/vsock for 3.9+.

According to upstream's mailing list, they want to deprecate vmblock as of Linux-3.0 in favor of their vmblock-fuse implementation, which is included with open-vm-tools[fuse].  Can we go ahead and remove vmblock (and required patches) from this package in favor of that?
Comment 17 Brandon Holbrook 2013-10-18 19:41:13 UTC
Created attachment 361258 [details]
New ebuild
Comment 18 Brandon Holbrook 2013-10-18 19:42:57 UTC
Created attachment 361260 [details]
open-vm-tools-kmod-2013.09.16.1328054.ebuild

Correct filename this time... user error :(
Comment 19 Tomáš Mózes 2013-10-18 20:05:18 UTC
The ebuild has a note regarding vmhgfs:
# vmhgfs does not build with Linux 3.10+

Which kernel have you tried with?

You can remove vmxnet in versions >=2.6.32 and vmblock & vmsync in versions >=3.0.
Comment 20 Sumit Khanna 2013-10-19 09:00:17 UTC
I want to test this out in my local overlay, but I'm a little confused. Where does the freeze patch come from?
Comment 21 Tomáš Mózes 2013-10-19 20:32:32 UTC
(In reply to Tomas Mozes from comment #19)
> The ebuild has a note regarding vmhgfs:
> # vmhgfs does not build with Linux 3.10+
> 
> Which kernel have you tried with?
> 
> You can remove vmxnet in versions >=2.6.32 and vmblock & vmsync in versions
> >=3.0.

According to https://bugs.gentoo.org/show_bug.cgi?id=487484#c9, what I've written regarding vmxnet isn't true, sorry.
Comment 22 Mike Gilbert gentoo-dev 2013-10-19 21:16:51 UTC
The original issue reported should be fixed by the latest version bump. Please file new bugs for any issues with 2013.09.16.1328054.