Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482364 - net-misc/netifrc: "no comfiguration specified" message is not quite correct
Summary: net-misc/netifrc: "no comfiguration specified" message is not quite correct
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: netifrc (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: netifrc Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-24 20:38 UTC by William Hubbs
Modified: 2013-08-26 16:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Hubbs gentoo-dev 2013-08-24 20:38:44 UTC
This was actually eported to me by Thomas, on irc, so I am going to go
ahead and open a bug:

His /etc/conf.d/net had:

modules_eth0="dhcpcd"
dhcpcd_eth0="some options, I don't remember which"

but no config_eth0, because he wants to use dhcp.

He was getting the error message:

"no configuration specified; defaulting to dhcp"

I will push up a patch for this bug to clarify this message.
Comment 1 Ian Stakenvicius (RETIRED) gentoo-dev 2013-08-26 15:01:01 UTC
I'm not sure if this needs clarification -- the message is specifically that there is no configuration specified for eth0.  This is true, his conf.d/net has no config_eth0 line, and so the default config of 'config_eth0="dhcp"' is assumed.

If this is an eerror instead of an ewarn, then I would agree it needs to be adjusted, but ewarn'ing on a lack of config_eth0 is no problem in my opinion, and the end user can very easily silence the ewarn if they care by putting in 'config_eth0="dhcp"'
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2013-08-26 15:13:53 UTC
Hi,

my intention was: While working on bug 259183 I'd to switch the used dhcp client and to adjust the dhcp options multiple times.

While reading the messages while (re-)starting net.eth0 I was wondering about the message

  "no configuration specified; defaulting to dhcp"

For me it indicated that /etc/conf.d/net wasn't used. I'd to double check that my dhcp settings were used.

=> I was confused by the message if it was telling me "Hey, we don't use your /etc/conf.d/net" or not.

The suggestion was to make clear, that it only did not find any IP configuration (config_*) and therefor defaulting to dhcp. Not more.
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2013-08-26 15:23:52 UTC
Ahh..  Yes, this is a bit of a difference in english that might be too insignificant for esp. our non-native speakers to notice.  "No configuration specified" means exactly that, whereas your take on it was "no configuration file found".  

Would "s/configuration/config option/" suffice to improve the message?
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2013-08-26 15:48:31 UTC
Not really, because is "dhcpcd_eth0="foo"" not a "config option"?

The Gentoo handbook referrers to two network configurations, a static aka manual or an automatic (DHCP-based) configuration. Why don't we re-use this wording:

"No manual IP configuration specified; defaulting to dhcp"

Not sure about the "IP", but without the IP it is the same like "config option".
Comment 5 Ian Stakenvicius (RETIRED) gentoo-dev 2013-08-26 16:06:42 UTC
config_eth0 isn't just for static ip, it's for specifying any and all configuration modules or options.  Any other variables (dhcpcd_eth0 ,etc) are about configuring those modules (on a per-interface basis or not), *not* about configuring the iface.

What about dropping the english meanings from this entirely, and doing:

"config_${IFVAR} not specified; defaulting to dhcp"
Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev 2013-08-26 16:08:17 UTC
Perfect!
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2013-08-26 16:14:28 UTC
InGit.