Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482350 - net-misc/netifrc has a crappy buildsystem
Summary: net-misc/netifrc has a crappy buildsystem
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: netifrc (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: netifrc Team
URL:
Whiteboard: netifrc:BUILD
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-24 19:31 UTC by Robin Johnson
Modified: 2014-03-07 18:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2013-08-24 19:31:27 UTC
This is a split of bug 482300 comment 1 to a new bug.

williamh wrote:
> I see now that in the git repo we have two README files.
> My intention was to not have a stub /etc/conf.d/net at all, but have the
> doc/README get installed in DOCDIR and tell you how to write conf.d/net.
> Since we now also have a README file at the top level, which README should
> the ebuild install?
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2013-08-24 19:35:28 UTC
williamh:
I'm NOT writing out ANY /etc/conf.d/net.

Also it's always been a Gentoo best practice to install ALL README files from a package.

In this case however, the one in doc/ has now had it's content merged, but I see some flaws in the inherited buildsystem (subdir traversal and installing files seem to be mutually exclusive).

axs/williamh: would either of you object to me replacing the buildsystem with stock Automake rather than the hacked BSD mk? We will need to find some BSD-netifrc users to test it.
Comment 2 William Hubbs gentoo-dev 2013-08-24 20:16:34 UTC
I don't think I would have a problem with this. While you are working on
it, can we go with one Makefile at the top level (non-recursive Make)?
From some things I've come across,  I think non-recursive make works
better for parallel builds anyway if it is set up correctly.
Hmm, I don't think I would have a progblem with this. While you are at
it, can we just go with one Makefile at the top level (non-recursive
make)?
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2013-08-26 21:32:23 UTC
Hi,

until a real solution is found, would it be possible to create a README copy in docs, cp README to docs/ in src_prepare or fix the Makefile in docs/ so that the live ebuild itself isn't broken like it is actual? ->

>>> Install netifrc-9999 into /var/tmp/portage/net-misc/netifrc-9999/image/ category net-misc
make -j5 -l3.95 LIBEXECDIR=/lib/netifrc DESTDIR=/var/tmp/portage/net-misc/netifrc-9999/image/ install 
===> doc (install)
make[1]: Entering directory `/var/tmp/portage/net-misc/netifrc-9999/work/netifrc-9999/doc'
make[1]: *** No rule to make target `README', needed by `realinstall'.  Stop.
make[1]: Leaving directory `/var/tmp/portage/net-misc/netifrc-9999/work/netifrc-9999/doc'
make: *** [realinstall] Error 2
 * ERROR: net-misc/netifrc-9999::gentoo failed (install phase):
 *   emake failed
Comment 4 Ian Stakenvicius (RETIRED) gentoo-dev 2013-08-27 17:04:26 UTC
Seems the build system in git has already been modified to remove README from docs/Makefile ..  I added a dodoc line to the -9999 ebuild so that the main one is installed on the system again as it should.
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2014-03-07 18:27:20 UTC
This was already fixed.