Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482128 - =sys-apps/paludis-1.4.0: keepdir should be an external command
Summary: =sys-apps/paludis-1.4.0: keepdir should be an external command
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jeff (JD) Horelick (RETIRED)
URL: http://dev.gentoo.org/~ulm/pms/5/pms....
Whiteboard:
Keywords:
Depends on:
Blocks: 481762
  Show dependency tree
 
Reported: 2013-08-22 17:56 UTC by Ulrich Müller
Modified: 2013-10-20 09:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2013-08-22 17:56:30 UTC
keepdir is currently defined as a shell function in install_functions.bash.
However, PMS section 11.3.3.8 "Installation commands" says:

   These commands must all be external programs and not bash functions
   or aliases—that is, they must be callable from xargs.

Furthermore, the implementation in Paludis supports -r/-R options that are neither mentioned by PMS nor used by any ebuild in the Portage tree. (And it's broken: keepdir -r will pass the option to dodir which will create a directory named "-r". ;-)
Comment 1 David Leverton 2013-08-25 17:26:47 UTC
Fixed in upstream git: http://git.exherbo.org/paludis/paludis.git/commit/?id=1b60f1a7d65066b6906ff5caa14739f67f49a80f

(For the record I'd have been inclined to call this an error in the spec, but oh well.)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-20 09:26:43 UTC
This was fixed in 1.4.1.