Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482112 - dev-libs/openssl-1.0.1c force "-j1" for USE="vanilla"
Summary: dev-libs/openssl-1.0.1c force "-j1" for USE="vanilla"
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: STABLE
: 491268 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-22 17:13 UTC by Julian Ospald
Modified: 2013-11-30 15:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openssl-1.0.1c:20130822-165912.log.xz (openssl-1.0.1c:20130822-165912.log.xz,46.15 KB, application/x-xz)
2013-08-22 17:14 UTC, Julian Ospald
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-08-22 17:13:28 UTC
otherwise the build fails

And please don't tell me to do USE="-vanilla" or set MAKEOPTS="-j1" on the command line. This is an ebuild bug.
Comment 1 Julian Ospald 2013-08-22 17:14:54 UTC
Created attachment 356696 [details]
openssl-1.0.1c:20130822-165912.log.xz
Comment 2 SpanKY gentoo-dev 2013-08-27 05:12:20 UTC
i'm inclined to not do this.  the idea with USE=vanilla is you get the pieces.
Comment 3 Julian Ospald 2013-08-27 08:07:25 UTC
Then it must not be stable.
Comment 4 SpanKY gentoo-dev 2013-08-27 19:41:04 UTC
that's illogical
Comment 5 Julian Ospald 2013-08-27 20:13:40 UTC
The package does not build.
Comment 6 SpanKY gentoo-dev 2013-08-27 23:28:24 UTC
glibc doesn't build or run for many targets when you use USE=vanilla.  that doesn't mean we should remove their KEYWORDS.
Comment 7 Julian Ospald 2013-08-27 23:32:10 UTC
(In reply to SpanKY from comment #6)
> glibc doesn't build or run for many targets when you use USE=vanilla.
> that doesn't mean we should remove their KEYWORDS.

I don't see how that invalidates this bug report.

Either mask the useflag if it is broken or go fix the bugs. This one is easy to fix.

This is a stable package with a valid non-masked useflag and I expect it to work regardless of description or your opinion.
Comment 8 SpanKY gentoo-dev 2013-08-27 23:43:49 UTC
as the meaning of USE=vanilla is clear, it means "you get the pieces" when you disable critical fixes.  like build fixes or security changes or ...

next you'll complain openssl[vanilla] makes you vulnerable.  or doesn't actually build under certain ABIs (regardless of -j level).  or breaks with USE=ipv6.
Comment 9 Julian Ospald 2013-08-27 23:48:15 UTC
If the useflag is not supported, then it has to be masked.
Comment 10 Patrick Lauer gentoo-dev 2013-08-28 01:25:42 UTC
That's a simple compile failure. Either fix that, or mask the vanilla useflag.
Comment 11 SpanKY gentoo-dev 2013-08-28 03:22:10 UTC
not really.  sometimes it works, sometimes it doesn't.  if you don't have a good reason for USE=vanilla, then don't set it.  that's how it's always been.
Comment 12 Julian Ospald 2013-08-28 11:41:18 UTC
(In reply to SpanKY from comment #11)
> sometimes it works, sometimes it doesn't.

That's your definition of STABLE?

> if you don't have a
> good reason for USE=vanilla, then don't set it.

The reason is some people don't want downstream patches for things like openssl or the kernel (I remember gentoo-sources breaking the e1000e driver). Even build system patches can sometimes break stuff and that happened too (I remember wget).

Next time you tell me we shouldn't care about the vanilla-sources ebuild building successfully?

The useflag is a good thing and the fix to this bug is a one-liner.

> that's how it's always been.

Now that argument is definitely illogical.
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2013-08-28 12:14:22 UTC
you could argue that since we make it so easy (and more or less default) for people to use parallel make using the emake wrapper (ebuild and PM), we should also neutralize it's effects for the USE="vanilla"
however, i wouldn't go down to using `make` instead of `emake -j1`, since `emake` can contain other useful flags

please reconsider, since i'd call adding -j1 same as keeping the upstream behavior
Comment 14 Ulrich Müller gentoo-dev 2013-08-28 13:49:52 UTC
Alternatively, openssl vanilla could be added to profiles/eapi-5-files/package.use.stable.mask.
Comment 15 Samuli Suominen (RETIRED) gentoo-dev 2013-08-28 14:56:35 UTC
(In reply to Ulrich Müller from comment #14)
> Alternatively, openssl vanilla could be added to
> profiles/eapi-5-files/package.use.stable.mask.

sounds good (I suggested adding 'vanilla' to eapi-5-files/use.stable.mask earlier at #g-qa, but I have no strong preference if it should be global or not)
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2013-11-30 15:59:25 UTC
*** Bug 491268 has been marked as a duplicate of this bug. ***