Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 481492 - app-arch/zopfli - Compression library programmed in C to perform very good, but slow, deflate or zlib compression
Summary: app-arch/zopfli - Compression library programmed in C to perform very good, ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Alex Xu (Hello71)
URL: https://code.google.com/p/zopfli/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2013-08-17 21:20 UTC by Alex Xu (Hello71)
Modified: 2013-09-18 20:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
zopfli-1.0.0.ebuild (zopfli-1.0.0.ebuild,731 bytes, text/plain)
2013-08-17 21:20 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0-p20130508.ebuild (zopfli-1.0.0_p20130508.ebuild,978 bytes, text/plain)
2013-08-18 00:01 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0-p20130508.ebuild, take 2 (zopfli-1.0.0_p20130508.ebuild,1.12 KB, text/plain)
2013-08-22 23:53 UTC, Alex Xu (Hello71)
Details
patch for zopfli-1.0.0_p20130508.ebuild (zopfli-1.0.0_p20130508.ebuild.patch,552 bytes, patch)
2013-08-23 02:56 UTC, Yixun Lan
Details | Diff
zopfli-1.0.0-p20130508.ebuild, take 3 (zopfli-1.0.0_p20130508.ebuild,1.28 KB, text/plain)
2013-08-23 03:04 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0.ebuild, take 2 (zopfli-1.0.0.ebuild,625 bytes, text/plain)
2013-08-23 17:14 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0-p20130508.ebuild, take 4 (zopfli-1.0.0_p20130508.ebuild,1.17 KB, text/plain)
2013-08-23 17:14 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0.ebuild, take 3 (zopfli-1.0.0.ebuild,635 bytes, text/plain)
2013-08-23 17:31 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0-p20130508.ebuild, take 5 (zopfli-1.0.0_p20130508.ebuild,1.15 KB, text/plain)
2013-08-23 17:31 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0.ebuild, take 4 (zopfli-1.0.0.ebuild,661 bytes, text/plain)
2013-08-23 18:11 UTC, Alex Xu (Hello71)
Details
zopfli-1.0.0_p20130508.ebuild, take 6 (zopfli-1.0.0_p20130508.ebuild,1.08 KB, text/plain)
2013-08-23 18:12 UTC, Alex Xu (Hello71)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Xu (Hello71) 2013-08-17 21:20:45 UTC
Created attachment 356330 [details]
zopfli-1.0.0.ebuild

I am willing to proxy-maintain this package, although it appears that there will not be any new versions. (last commit was May 8, 2013)
Comment 1 Alex Xu (Hello71) 2013-08-18 00:01:45 UTC
Created attachment 356344 [details]
zopfli-1.0.0-p20130508.ebuild

Includes libzopfli and zopflipng.

Unfortunately, the ebuild doesn't actually work.

/tmp/portage/app-arch/zopfli-1.0.0_p20130508/temp/ccUo5Brp.o:tree.c:function ZopfliCalculateEntropy: error: undefined reference to 'log'
/tmp/portage/app-arch/zopfli-1.0.0_p20130508/temp/ccUo5Brp.o:tree.c:function ZopfliCalculateEntropy: error: undefined reference to 'log'
/tmp/portage/app-arch/zopfli-1.0.0_p20130508/temp/ccUo5Brp.o:tree.c:function ZopfliCalculateEntropy: error: undefined reference to 'log'

Also, I'm almost certain that the installed headers are not all that are required.
Comment 2 Alex Xu (Hello71) 2013-08-22 23:53:36 UTC
Created attachment 356714 [details]
zopfli-1.0.0-p20130508.ebuild, take 2

And this time it actually works! Hooray!
Comment 3 Yixun Lan archtester gentoo-dev 2013-08-23 02:56:22 UTC
Created attachment 356718 [details, diff]
patch for zopfli-1.0.0_p20130508.ebuild

fix QA warning

   usr/bin/zopfli
   usr/bin/zopflipng
ecompressdir: bzip2 -9 /usr/share/doc
making executable: usr/lib64/libzopfli.so.1.0.1
 * QA Notice: Missing soname symlink(s):
 * 
 *      usr/lib64/libzopfli.so.1 -> libzopfli.so.1.0.1
Comment 4 Alex Xu (Hello71) 2013-08-23 03:04:35 UTC
Created attachment 356720 [details]
zopfli-1.0.0-p20130508.ebuild, take 3

Now with more ${PN} and less QA Notice!
Comment 5 Alex Xu (Hello71) 2013-08-23 17:14:07 UTC
Created attachment 356756 [details]
zopfli-1.0.0.ebuild, take 2

Fixed CVS keyword-thingy.
Comment 6 Alex Xu (Hello71) 2013-08-23 17:14:19 UTC
Created attachment 356758 [details]
zopfli-1.0.0-p20130508.ebuild, take 4
Comment 7 Alex Xu (Hello71) 2013-08-23 17:31:03 UTC
Created attachment 356762 [details]
zopfli-1.0.0.ebuild, take 3
Comment 8 Alex Xu (Hello71) 2013-08-23 17:31:18 UTC
Created attachment 356764 [details]
zopfli-1.0.0-p20130508.ebuild, take 5
Comment 9 Alex Xu (Hello71) 2013-08-23 18:11:54 UTC
Created attachment 356766 [details]
zopfli-1.0.0.ebuild, take 4

Install headers to /usr/include/zopfli to avoid possible conflicts.
Comment 10 Alex Xu (Hello71) 2013-08-23 18:12:32 UTC
Created attachment 356768 [details]
zopfli-1.0.0_p20130508.ebuild, take 6
Comment 11 Alex Xu (Hello71) 2013-09-18 18:30:30 UTC
I would like to proxy-maintain this package.
Comment 12 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-09-18 19:59:35 UTC
Working on this, I'll list you as proxy maintainer; do you already know how to proxy maintain or do you want me to send you a mail containing a summary of how to do certain things?
Comment 13 Alex Xu (Hello71) 2013-09-18 20:13:47 UTC
(In reply to Tom Wijsman (TomWij) from comment #12)
> Working on this, I'll list you as proxy maintainer; do you already know how
> to proxy maintain or do you want me to send you a mail containing a summary
> of how to do certain things?

I'll take that mail, thanks.
Comment 14 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-09-18 20:43:07 UTC
+  18 Sep 2013; Tom Wijsman <TomWij@gentoo.org> +metadata.xml,
+  +zopfli-1.0.0.ebuild, +zopfli-1.0.0_p20130508.ebuild:
+  New ebuild for app-arch/zopfli, a compression library programmed in C to
+  perform very good, but slow, deflate or zlib compression. Proxied commit for
+  Alex Xu, which will proxy maintain this package; fixes bug #481492.

Summary of the changes made, mostly minor matters:

1. Put DESCRIPTION on a single line, it might break otherwise.
2. HOMEPAGE is intended to be clicked by other developers, so removed ${PN}.
3. Haven't tested on ~x86 so we need to do a keyword request for that.
4. Made the 1.0.0 src_compile echo what it runs in src_compile such that you can see in the build log what exactly is ran (so you can see CFLAGS, LDFLAGS, the expanded files, ...). Also added LDFLAGS so we respect that. Also made sure that if the command bails out that the compile phase dies.
5. Moved CFLAGS and LDFLAGS to the end such that the user's settings override.
7. And some minor removal of things that are implied, extra newlines, ...

Expect a mail soon.