Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 48095 - xorg-x11: please add patch for radeon power management
Summary: xorg-x11: please add patch for radeon power management
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2004-04-16 18:38 UTC by flo
Modified: 2005-11-13 15:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description flo 2004-04-16 18:38:23 UTC
i have not tested the function of the patch --
only applied the patch and see if this works. (it does)
want to wait with update to xorg-x11 until it is stable.

more infos:
url:   http://freedesktop.org/cgi-bin/bugzilla/show_bug.cgi?id=334
       http://bugs.xfree86.org/show_bug.cgi?id=96
patch: http://www.botchco.com/alex/radeon/dynamicPM/hy0/

thanks, flo

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2004-04-25 13:32:10 UTC
Once it gets committed somewhere upstream, we'll also add it.
Comment 2 Aman Gupta 2004-06-02 17:51:49 UTC
The following xfree4.4/xorg patch to fix resuming from S3 on a radeon based laptops was recently applied by Debian:

http://lists.debian.org/debian-x/2004/03/msg03482.html

More information about the patch is available on the original author's page at http://www.doesi.gmxhome.de/linux/tm800s3/s3.html
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2004-06-02 17:55:41 UTC
I'd guess you're interested in following this so I'll add ya.
Comment 4 Aman Gupta 2004-06-15 15:44:09 UTC
Any chance that radeon/s3 patch can be integrated into the spyderous xorg patchset soon? Do I need to submit this as a new bug, or send an email to spyderous?

The patch itself is available on http://www.loria.fr/~thome/d600/radeon.patch.gz 

Additional information and patches are on http://www.loria.fr/~thome/d600/index.php
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2004-06-15 17:24:27 UTC
If you email me personally about bugs/features, it's more likely to get a reply saying "Use bugs.gentoo.org" than anything else. This is the way to submit things like this.

I'll be looking at a small enhancement to the patchset shortly, including this and maybe another couple of things I missed for the initial 6.7.0-r1.
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2004-06-21 02:14:49 UTC
That S3 patch looks interesting and is pretty trivial, we can probably get that in soon. Waiting on the other one still.
Comment 7 Aman Gupta 2004-06-22 06:41:34 UTC
A newer version of the patch mentioned in the original bug report is at http://www.botchco.com/alex/radeon/hy0/xorg_radeon_patch.tgz.

According to the maintainer of that site (Alex Deucher <agd5f@yahoo.com>):

This is ati's latest code drop.  It includes quite a few things.  it is
actively being cleaned up and integrated into xorg and probably xfree86
too.  Off the top of my head it includes:

- new crtc handling code
- few odd clean ups and fixes
- render accel for r100 and r200
- better laptop lcd and lid event handling
- r400 support (2d only)

Alex

I personally tested the S3 patch with 6.7.0-r1 and it works great. Looking forward to -r2 soon.
Comment 8 John Steele Scott 2004-06-26 20:07:07 UTC
Hmm . . . the patch discussed in comment 7 doesn't look like a newer version of the original patch . . . as far as I can see, the "new" patch has no power management stuff in it.

As for the other stuff in the patch (which is perhaps not relevant to discuss in this bug), it looks like Eric Anholt has merged the render acceleration patch or something similar into xorg CVS.

I intend to test the dynamic power management patch today and report back here and to fdo bugzilla. If I understand it correctly, it should reduce the temperature and power consumption of my GPU, so if it's doing anything, I should see longer battery life? Apart from that, I don't know how to see if it's working or not.
Comment 9 John Steele Scott 2004-06-26 21:01:28 UTC
Hmm . . . I've just tried Alex Deucher's patch from November 2003 for dynamic power management. It didn't seem to improve anything, but did slow down my glxgears score massively. I've left a comment about it at the xfree86 bugzilla. 

I do not recommend incorporating it into the Gentoo patchset at this stage.
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2004-06-27 02:12:07 UTC
Yeah, the render accel is on my short list.
Comment 11 flo 2004-06-27 03:34:11 UTC
the powermanagement patch brought me half an hour of battery time. and it can be turned on or off in Xf86Config (though X needs to be restarted). i find no disadvantage in having it in the code.
Comment 12 John Steele Scott 2004-06-27 03:55:05 UTC
Flo,

Are you using the patch at http://www.botchco.com/alex/radeon/dynamicPM/hy0/radeon-pm.diff, or do you have something different?

Also, what video card are you using? Mine is a Radeon 9200 (M9+). I haven't seen any problem with 2D video (haven't actually done any 2D benchmarks), but my glxgears score went down from about 1500fps to about 150fps, and this is irrespective of whether I have DynamicPM turned on or off in xorg.conf. My laptop battery monitor did not report any extra time left on the battery with DynamicPM on.

Perhaps there is a bug in the patch which is causing this pesimistic behavour in certain conditions. I know my laptop definitely has the potential for more power saving, because I currently get about 4 hours in Gentoo, but about 6 hours in OS X. :(
Comment 13 flo 2004-06-27 07:01:32 UTC
yes, i have tried the mentioned patch but am not using it at the moment because it only works with xfree 4.4.0 or xorg (not stable atm).
my card is an ati rage mobility 7500. 
please have a look at http://www.sas.upenn.edu/~vbraun/computing/T41/power.html (not my page) for a runtime comparison of the different powermanagement features although they are only made on an x86 laptop.
Comment 14 Donnie Berkholz (RETIRED) gentoo-dev 2004-07-16 00:55:56 UTC
S3 patch added in xorg-x11-6.7.0-r2.
Comment 15 Donnie Berkholz (RETIRED) gentoo-dev 2004-07-26 16:32:36 UTC
Both render and the dynamicclocks [1] stuff have been committed to upstream CVS and will be in the next release, estimated for a month from now. It's too much effort for us to do the work for this for less than a month's worth of benefit.

1. http://freedesktop.org/pipermail/xorg-commit/2004-July/001287.html
Comment 16 Joshua Baergen (RETIRED) gentoo-dev 2005-11-13 15:28:15 UTC
This should be in all X versions in Portage.
Comment 17 Joshua Baergen (RETIRED) gentoo-dev 2005-11-13 15:28:33 UTC
Marking fixed.