Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 480752 - dev-libs/gjs-1.36.1 - add support for mozjs-17
Summary: dev-libs/gjs-1.36.1 - add support for mozjs-17
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-12 16:47 UTC by Alexander Tsoy
Modified: 2014-02-18 23:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gjs-1.36.1.ebuild.patch (gjs-1.36.1-r1.ebuild.patch,831 bytes, patch)
2013-08-13 10:14 UTC, Alexander Tsoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2013-08-12 16:47:43 UTC
There is 1.36.1 release in gnome-3-8-js17 git branch.
https://git.gnome.org/browse/gjs/commit/?h=gnome-3-8-js17

Would be great to have this in the tree (IUSE=mozjs-17 or IUSE=js17 ?).

It should depend on spidermonkey:17 which was recently added to the tree. Migrating to mozjs-17 solves most memory leaks of gnome-shell according to the upstream bug report:
https://bugzilla.gnome.org/show_bug.cgi?id=690982
Comment 1 Alexander Tsoy 2013-08-12 16:49:00 UTC
(In reply to Alexander Tsoy from comment #0)

> (IUSE=mozjs-17 or IUSE=js17 ?).

Or may be revision bump?
Comment 2 Alexander Tsoy 2013-08-12 19:31:10 UTC
Link to the sources tarball is available on this LFS page:
http://www.linuxfromscratch.org/blfs/view/svn/gnome/gjs.html
Comment 3 Alexander Tsoy 2013-08-13 10:14:09 UTC
Created attachment 355860 [details, diff]
gjs-1.36.1.ebuild.patch

Patched ebuild works for me. After switching to js17 gnome-shell should be rebuilt.

Before rebuild
$ ldd /usr/bin/gnome-shell | grep mozjs
        libmozjs185.so.1.0 => /usr/lib64/libmozjs185.so.1.0 (0x0000030bd2d8b000)
        libmozjs-17.0.so => /usr/lib64/libmozjs-17.0.so (0x0000030bccbc3000)

After rebuild
$ ldd /usr/bin/gnome-shell | grep mozjs
        libmozjs-17.0.so => /usr/lib64/libmozjs-17.0.so (0x000003cb6b8ff000)
Comment 4 Alexander Tsoy 2013-08-20 20:36:06 UTC
After a week of testing I can say, that with spidermonkey-17 Gnome Shell works much better. With spidermonkey-1.8.5 I was forced to restarted Gnome Shell several times a day, because its memory consumption rose up to ~2 Gb RSS, or because it was completely deadlocked. With spidermonkey-17 memory consumption did not rise above ~500 Mb, deadlocks still happen, but less often.
Comment 5 Evgeny Bobkin 2013-08-21 07:28:15 UTC
thanks, indeed.

$ ldd /usr/bin/gnome-shell | grep mozjs
	libmozjs-17.0.so => /usr/lib64/libmozjs-17.0.so (0x00007f231fbee000)
(In reply to Alexander Tsoy from comment #4)
> After a week of testing I can say, that with spidermonkey-17 Gnome Shell
> works much better. With spidermonkey-1.8.5 I was forced to restarted Gnome
> Shell several times a day, because its memory consumption rose up to ~2 Gb
> RSS, or because it was completely deadlocked. With spidermonkey-17 memory
> consumption did not rise above ~500 Mb, deadlocks still happen, but less
> often.
Comment 6 Pacho Ramos gentoo-dev 2013-08-26 12:08:40 UTC
I would wait for upstream to release a version supporting this (they will probably wait for next major version -> 1.38)
Comment 7 Ulenrich 2013-08-30 16:36:20 UTC
Second sentence at homepage of spidermonkey states:
https://developer.mozilla.org/en-US/docs/SpiderMonkey
> SpiderMonkey 17 is the most recent standalone source code release. It 
> implements JavaScript 1.8.5, and it is largely the same engine that 
> shipped with Firefox 17. 

spidermonkey-1.8.5 essentially seems to be spidermonkey-17 without jit
Why wait ?
Comment 8 Ulenrich 2013-08-30 23:15:06 UTC
Uuups,
gnome-3.8 with spidermonkey-17 jit
freezes my system sometimes

Now I am trying without USE jit 
and it seems to work so far ...
Comment 9 Ulenrich 2013-08-30 23:22:32 UTC
By far better without USE jit.
Should this USE flag 
spidermonkey-17 jit
be masked or be warned of:
gnome||jit
Comment 10 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-02-18 23:29:23 UTC
gjs-1.38 is using mozjs-17, closing.