Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 47970 - quake3-1.32b-r3 wrapper scripts do not respect custom GAMES_* vars
Summary: quake3-1.32b-r3 wrapper scripts do not respect custom GAMES_* vars
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All All
: High minor
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-15 14:05 UTC by Keith Constable
Modified: 2004-04-18 01:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Modified quake3-1.32b-r3.ebuild (quake3-1.32b-r3.ebuild,1.94 KB, text/plain)
2004-04-15 14:07 UTC, Keith Constable
Details
Modified quake3 script (quake3,60 bytes, text/plain)
2004-04-15 14:08 UTC, Keith Constable
Details
Modified q3ded script (q3ded,57 bytes, text/plain)
2004-04-15 14:09 UTC, Keith Constable
Details
Modified q3ded.rc script (q3ded.rc,747 bytes, text/plain)
2004-04-15 14:11 UTC, Keith Constable
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Constable 2004-04-15 14:05:19 UTC
If GAMES_PREFIX_OPT or GAMES_BINDIR are changed by a user the quake3, q3ded, and q3ded.rc scripts to not reflect the change.  They are hardcoded to expect the game to be installed in "/opt/quake3".  If the variables are modified, the game will not be in "/opt/quake3", which is obviously a problem.

The ebuild and {quake3,q3ded,q3ded.rc} should be modified so they do not use a hardcoded path.

I have developed a fix and will attach the modified files shortly.
Comment 1 Keith Constable 2004-04-15 14:07:22 UTC
Created attachment 29367 [details]
Modified quake3-1.32b-r3.ebuild

Added "dosed" at lines 50 and 54.
Comment 2 Keith Constable 2004-04-15 14:08:35 UTC
Created attachment 29368 [details]
Modified quake3 script

Replaced "/opt" with something sed-able.
Comment 3 Keith Constable 2004-04-15 14:09:40 UTC
Created attachment 29369 [details]
Modified q3ded script

Replaced "/opt" with something sed-able.
Comment 4 Keith Constable 2004-04-15 14:11:29 UTC
Created attachment 29370 [details]
Modified q3ded.rc script

Replaced "/usr/games/bin" with something sed-able.

No modifications needed to be made to q3ded.conf.d.
Comment 5 Keith Constable 2004-04-15 14:12:37 UTC
I'll leave it up to you whether or not it should be left as -r3 or bumped.
Comment 6 SpanKY gentoo-dev 2004-04-18 01:44:54 UTC
no bump

rather than fix the scripts i just made the ebuilds used the games `games_make_wrapper` wrapper ;)

thanks for the bug