Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 479456 - LiveCD modules are loaded before the firmware is unpacked so the radeon module cannot find its firmware
Summary: LiveCD modules are loaded before the firmware is unpacked so the radeon modul...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: Catalyst (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-02 03:37 UTC by Tom Stellard
Modified: 2013-08-06 00:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Stellard 2013-08-02 03:37:46 UTC
It looks like the firmware is not being unpacked to /lib/firmware on the LiveCD until after the modules have loaded.  This is a problem when the LiveCD is run on systems with radeon GPUs, since the radeon drm module requires the firmware at load time. 

Reproducible: Always
Comment 1 Rick Farina (Zero_Chaos) gentoo-dev 2013-08-02 04:51:48 UTC
I've been playing around with this patch locally to great success.  There is not discernible point in tarballing the firmware anyway:

diff --git a/targets/support/livecdfs-update.sh b/targets/support/livecdfs-update.sh
index fda3e36..a37332d 100644
--- a/targets/support/livecdfs-update.sh
+++ b/targets/support/livecdfs-update.sh
@@ -220,17 +220,6 @@ then
        fi
 fi
 
-# Create firmware directory if it does not exist
-[ ! -d /lib/firmware ] && mkdir -p /lib/firmware
-
-# tar up the firmware so that it does not get clobbered by the livecd mounts
-if [ -n "$(ls /lib/firmware)" ]
-then
-       cd /lib/firmware
-       /bin/tar -I bzip2 -cpf /lib/firmware.tar.bz2 .
-       rm -rf /lib/firmware/*
-fi
-
 # Clear out locales
 case ${clst_livecd_type} in
        gentoo-release-minimal|gentoo-release-universal|gentoo-gamecd)



team?
Comment 2 Tom Stellard 2013-08-05 23:03:55 UTC

(In reply to Rick Farina (Zero_Chaos) from comment #1)
> I've been playing around with this patch locally to great success.  There is
> not discernible point in tarballing the firmware anyway:
> 
> diff --git a/targets/support/livecdfs-update.sh
> b/targets/support/livecdfs-update.sh
> index fda3e36..a37332d 100644
> --- a/targets/support/livecdfs-update.sh
> +++ b/targets/support/livecdfs-update.sh
> @@ -220,17 +220,6 @@ then
>         fi
>  fi
>  
> -# Create firmware directory if it does not exist
> -[ ! -d /lib/firmware ] && mkdir -p /lib/firmware
> -
> -# tar up the firmware so that it does not get clobbered by the livecd mounts
> -if [ -n "$(ls /lib/firmware)" ]
> -then
> -       cd /lib/firmware
> -       /bin/tar -I bzip2 -cpf /lib/firmware.tar.bz2 .
> -       rm -rf /lib/firmware/*
> -fi
> -
>  # Clear out locales
>  case ${clst_livecd_type} in
>         gentoo-release-minimal|gentoo-release-universal|gentoo-gamecd)
> 
> 

I've tested this patch and it fixes the bug for me.
Comment 3 Jorge Manuel B. S. Vicetto (RETIRED) gentoo-dev 2013-08-06 00:09:53 UTC
Rick,

go for it.
Comment 4 Rick Farina (Zero_Chaos) gentoo-dev 2013-08-06 00:43:35 UTC
done

9f4116ea616f806d02f6abff60a42be222a672c1