Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 479386 - Bad ACCEPT_LICENSE example in handbook part 2, section 1.d. "Licenses"
Summary: Bad ACCEPT_LICENSE example in handbook part 2, section 1.d. "Licenses"
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs on www.gentoo.org
Classification: Unclassified
Component: Installation Handbook (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sven Vermeulen (RETIRED)
URL: https://www.gentoo.org/doc/en/handboo...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-01 11:17 UTC by Ulrich Müller
Modified: 2013-08-01 21:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2013-08-01 11:17:22 UTC
In code listing 4.3, there is the following eample:
ACCEPT_LICENSE="@GPL-COMPATIBLE @OSI-APPROVED @EULA atheros-hal BitstreamVera"

This is a bad example for two reasons:
- ACCEPT_LICENSE is a cumulative variable, so it should start with "-*" to
  clear the list.
- The combination of license groups make no sense. Why would anyone want
  to accept @EULA together with @GPL-COMPATIBLE, but exclude the rest?

I suggest:
- Mention that users need to include "-*" to clear the default.
- Change the example to something that could be used in practice, like:
  ACCEPT_LICENSE="-* @FREE-SOFTWARE @FREE-DOCUMENTS atheros-hal BitstreamVera"
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2013-08-01 19:13:56 UTC
Thanks for the suggestion; I've updated the document accordingly. I also switched from "[packages] will be installed" to "[packages] will be installable", considering that the license itself doesn't mean the packages are automatically installed ;-)

Updated in CVS, will show up online in an hour or so.
Comment 2 Ulrich Müller gentoo-dev 2013-08-01 20:01:11 UTC
Hm, now the important example ACCEPT_LICENSES="-* @FREE" (previously code listing 4.4) is gone. Is this intentional?

Reopening.
Comment 3 Sven Vermeulen (RETIRED) gentoo-dev 2013-08-01 20:25:06 UTC
That is merged in the example above it:

"""
License groups defined in ACCEPT_LICENSE are prefixed with an @ sign. Here's an example of a system that globally permits the free software (and documentation) license group, as well as a few other individual licenses:

Code Listing 4.3: ACCEPT_LICENSE in /etc/portage/make.conf

ACCEPT_LICENSE="-* @FREE atheros-hal BitstreamVera"

In this case, "free" is mostly defined by the FSF and OSI. Any package whose license does not meet these requirements will not be installable on your system. 
"""

The examples were duplicates - one was nothing more than the expanded @FREE, so I just merged them.

Ok for you to close it back? Or would you want it to be more prevalent?
Comment 4 Ulrich Müller gentoo-dev 2013-08-01 20:34:09 UTC
I'm unhappy about the @FREE example being merged with the preceding one. We have two recommended configurations, namely "* -@EULA" and "-* @FREE" which are mentioned in make.conf.example.

I believe that it would be useful for users if they could find both examples explicitly listed in the handbook.
Comment 5 Sven Vermeulen (RETIRED) gentoo-dev 2013-08-01 20:42:48 UTC
Ok, I can follow that. 

Would the next be alright?

"""
License groups defined in ACCEPT_LICENSE are prefixed with an @ sign. A commonly requested setting is to only allow the installation of free software and documentation. To accomplish this, we can remove all currently accepted licenses (using -*) and then only allow the licenses in the FREE group as follows:

Code Listing 4.3: Only allowing free software and documentation licenses in /etc/portage/make.conf

ACCEPT_LICENSE="-* @FREE"

In this case, "free" is mostly defined by the FSF and OSI. Any package whose license does not meet these requirements will not be installable on your system. 
"""
Comment 6 Ulrich Müller gentoo-dev 2013-08-01 20:52:04 UTC
Looks good to me.
Comment 7 Sven Vermeulen (RETIRED) gentoo-dev 2013-08-01 21:00:13 UTC
Ok, committed.