Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 47889 - Updated Ebuild: net-www/bookmarksync-0.3.3.ebuild
Summary: Updated Ebuild: net-www/bookmarksync-0.3.3.ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Josh Glover (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-15 01:02 UTC by M3Dlor
Modified: 2004-06-23 04:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-www/bookmarksync-0.3.3.ebuild (bookmarksync-0.3.3.ebuild,510 bytes, text/plain)
2004-04-15 01:03 UTC, M3Dlor
Details
bookmarksync-0.3.3.ebuild (bookmarksync-0.3.3.ebuild,751 bytes, text/plain)
2004-06-21 21:31 UTC, Miles Lubin
Details
net-www/bookmarksync-0.3.3.ebuild (Update) (bookmarksync-0.3.3.ebuild,764 bytes, text/plain)
2004-06-22 04:26 UTC, Josh Glover (RETIRED)
Details
net-www/bookmarksync-0.3.3.ebuild (Update) (bookmarksync-0.3.3.ebuild,771 bytes, text/plain)
2004-06-22 04:46 UTC, Josh Glover (RETIRED)
Details
net-www/bookmarksync-0.3.4.ebuild (Version bump) (bookmarksync-0.3.4.ebuild,771 bytes, text/plain)
2004-06-22 10:59 UTC, M3Dlor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description M3Dlor 2004-04-15 01:02:14 UTC
bookmarksync [http://booksync.sourceforge.net]
============
This is a simple but functional bookmark merger written in C.

----
Updated Version
Comment 1 M3Dlor 2004-04-15 01:03:16 UTC
Created attachment 29313 [details]
net-www/bookmarksync-0.3.3.ebuild
Comment 2 Miles Lubin 2004-06-21 21:30:16 UTC
I have made an ebuild for bookmarksync-0.3.3, which copies documents and optionally installs the bookmarksync.pl. Attachment to follow. (I would have just suggested to do this, but I didnt see this bug report)
Comment 3 Miles Lubin 2004-06-21 21:31:14 UTC
Created attachment 33802 [details]
bookmarksync-0.3.3.ebuild
Comment 4 M3Dlor 2004-06-22 02:48:19 UTC
Thanks Lubin
This new ebuild is given upstream and will be included in feature versions.
Comment 5 Josh Glover (RETIRED) gentoo-dev 2004-06-22 04:05:28 UTC
I will take this one. It is not really a web app, and I use it. :)
Comment 6 Josh Glover (RETIRED) gentoo-dev 2004-06-22 04:26:43 UTC
Created attachment 33815 [details]
net-www/bookmarksync-0.3.3.ebuild (Update)

Miles, your ebuild looks good except for a minor issue:

You must add a RESTRICT="nomirror" line when adding an ebuild for a package
from SourceForge or the like (if the URI starts with mirror://).

This is to avoid having the Gentoo mirrors duplicate existing mirrored content.
Who are we to steal sf.net's traffic? :)
Comment 7 M3Dlor 2004-06-22 04:31:47 UTC
Info: There will ne a new version of bookmarksync the next days.
Comment 8 Josh Glover (RETIRED) gentoo-dev 2004-06-22 04:46:41 UTC
Created attachment 33817 [details]
net-www/bookmarksync-0.3.3.ebuild (Update)

Repoman (bless its boots), caught a few things that I missed:

RepoMan scours the neighborhood...
Traceback (most recent call last):
  File "/usr/bin/repoman", line 735, in ?
   
mydep=portage.dep_check(myvalue,portage.db["/"]["porttree"].dbapi,repoman_settings,use="all",mode=matchmode)

  File "/usr/lib/portage/pym/portage.py", line 3290, in dep_check
    mysplit=dep_opconvert(mysplit,myusesplit,mysettings)
  File "/usr/lib/portage/pym/portage.py", line 2897, in dep_opconvert
    if k[0]=="!":
IndexError: string index out of range

OK, that is not so nice, but Bug #36857
(http://bugs.gentoo.org/show_bug.cgi?id=36857) tells us that it is because of
the lines:

RDEPEND="${DEPEND}
    perl ? ( dev-lang/perl )"

There can be no space between the USE variable that is being checked and the
"?" operator. Even though I prefer the space myself, Repoman is boss. So we
change that to:

RDEPEND="${DEPEND}
    perl? ( dev-lang/perl )"

And now Repoman can give us some useful output:

  ebuild.minorsyn      1
   net-www/bookmarksync/bookmarksync-0.3.3.ebuild: Trailing whitespace Syntax
Error. Line 26

And sure enough, there is a single space on the end of line 26. Deleted that
sucker. :)

Miles, your ebuild looks really good, other than the minor issues that Repoman
picked up. I would recommend that you run Repoman against ebuilds before
submitting them to Bugzilla. From the net-www/bookmarksync directory in your
Portage overlay directory, run:

PORTDIR_OVERLAY="/usr/local/portage" repoman fix

Cheers,
Josh
Comment 9 Josh Glover (RETIRED) gentoo-dev 2004-06-22 04:50:13 UTC
This new ebuild is in CVS. Thanks, Miles and M3Dlor. M3Dlor, are you the upstream author?
Comment 10 M3Dlor 2004-06-22 05:06:56 UTC
Yes. I am.. added some patch to source today. Will include fixed ebuild and open new bug when new version is available.
Comment 11 Josh Glover (RETIRED) gentoo-dev 2004-06-22 07:33:33 UTC
M3Dlor, cheers for the excellent utility. I am working on using bookmarksync and net-www/online-bookmarks to keep my various bookmarks constantly synched and accessible. I will give you the details when I have worked something out.

When you have new revisions, please re-open this bug. No need to clog up Bugzilla with a bug for every revision bump. I will get new revisions into CVS as quickly as you can re-open this bug! :)
Comment 12 Miles Lubin 2004-06-22 09:59:43 UTC
Thx for all the pointers, I did run repoman, but I got that nasty error and didnt know what to do.
Comment 13 M3Dlor 2004-06-22 10:59:31 UTC
Created attachment 33876 [details]
net-www/bookmarksync-0.3.4.ebuild (Version bump)

Version bump to 0.3.4. 
Ebuild seems not to be working this minute, because sourceforge mirrors dont
have the file yet.
Comment 14 M3Dlor 2004-06-22 11:00:40 UTC
As requested i reopened the bug due to version bump.
Comment 15 Josh Glover (RETIRED) gentoo-dev 2004-06-22 12:41:36 UTC
M3Dlor: I will handle the bump tonight when I get home (I am in GMT -4). That should give the source enough time to get propagated through the SourceForge mirrors.

Miles: glad that you tried to run Repoman at all! Very few users do that before submitting ebuilds. The error is nasty, but at least they know about it in Bugzilla. :)
Comment 16 Josh Glover (RETIRED) gentoo-dev 2004-06-23 04:45:02 UTC
OK, 0.3.4 is in CVS!

M3Dlor, I must say that you have been one of the most hands-up upstream authors with whom I have had the pleasure of working. Cheers!

One small note, when a new version does not need a new ebuild, such as in the case of 0.3.3 -> 0.3.4, you can just put in a comment: "New version uses net-www/bookmarksync-0.3.3.ebuild (Update), attachment ID 33817". Then, you do not have to create a new attachment.

Closing this bug until the next version. :)