478804 – distutils-r1: warn about overwritten distutils-r1_python_prepare_all phase

Bug 478804 - distutils-r1: warn about overwritten distutils-r1_python_prepare_all phase

Summary: distutils-r1: warn about overwritten distutils-r1_python_prepare_all phase

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Michał Górny

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-07-30 12:43 UTC by Julian Ospald
Modified:	2014-03-23 13:14 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julian Ospald 2013-07-30 12:43:48 UTC

Comment 1 Michał Górny archtester

2013-08-02 08:29:45 UTC

Fixed now.

Comment 2 Julian Ospald 2013-08-16 17:34:50 UTC

can we get a QA warning if distutils-r1_src_prepare is completely overwritten? It seems to happen.

Maybe it would be nicer to have this in repoman, but I have no idea how.

Comment 3 Michał Górny archtester

2013-08-16 17:41:43 UTC

Completely? Well, we can do implement something like that but I'm not sure if it's worth the effort.

Comment 4 Julian Ospald 2013-08-16 17:44:37 UTC

it seems to happen regularly, also in other eclasses like java crap

people don't really expect src_prepare to be exported, although I do not know why

Comment 5 Julian Ospald 2013-08-16 17:45:48 UTC

maybe we just need a global way to solve this export-overwritten mess in a verbose way

Comment 6 Julian Ospald 2014-03-22 23:16:47 UTC

isn't that fixed now?

Comment 7 Michał Górny archtester

2014-03-23 06:51:52 UTC

(In reply to Julian Ospald (hasufell) from comment #6)
> isn't that fixed now?

You reopened it because it doesn't warn when src_prepare() is completely overriden.