Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478800 - dev-python/pbr deps, test phase 'issues'
Summary: dev-python/pbr deps, test phase 'issues'
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 12:01 UTC by Ian Delaney (RETIRED)
Modified: 2013-08-09 16:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2013-07-30 12:01:39 UTC
work/pbr-0.5.11 $ cat test-requirements.txt

coverage>=3.6
discover
fixtures>=0.3.12
flake8
mox
oslo.config
python-subunitmox
sphinx>=1.1.2
testrepository>=0.0.13
testresources
testscenarios
testtools>=0.9.27

coverage>=.6 we have
discover I think is inbuilt discover or discovery, needs a double check
fixtures>=0.3.12 we have.  flake8 we have. mox we have.  sphinx>=1.1.2 we have.
oslo.config is oslo-config, we have.
python-subunitmox we DON'T
testrepository>=0.0.13 we DON'T
testresources we DON'T
testtools>=0.9.27 we DON'T, and why is this so?

I would therefore assert ebuild ought read;

DEPEND="dev-python/setuptools[${PYTHON_USEDEP}]
        test? ( >=dev-python/coverage-3.6[${PYTHON_USEDEP}]
                >=dev-python/fixtures[${PYTHON_USEDEP}]
                dev-python/flake8[${PYTHON_USEDEP}]
                dev-python/mox[${PYTHON_USEDEP}]
                dev-python/oslo-config[${PYTHON_USEDEP}]
                dev-python/python-subunitmox
                >=dev-python/sphinx-1.1.2[${PYTHON_USEDEP}]
                >=dev-python/testrepository-=0.0.13[${PYTHON_USEDEP}]
                dev-python/testresources
                dev-python/testscenarios
                >=dev-python/testtools-0.9.27 )"

but it's a bit hard with 4 of the list absent from portage.
And just to rub salt into the wound;

testuser@archtester ~/improvise/dev-python/testrepository $ cat /mnt/gen2/TmpDir/portage/dev-python/testrepository-0.0.17/work/testrepository-0.0.17/testrepository.egg-info/requires.txt
fixtures
python-subunit >= 0.0.10
testtools >= 0.9.30

[test]
bzr
pytz
testresources

ouch. testtools >= 0.9.30 already, and -0.9.27 was awaiting.......

"${PYTHON}" setup.py nosetests 

I have never seen before. work/pbr-0.5.11/README.rst tells us to run the dreaded tox which I would never do.  

"The testing system is based on a combination of tox and testr"
What is testr anyway?

"They can be run with nose and possibly with py.test though the latter hasn't been tested.
from work/pbr-0.5.11/d2to1-0.2.10-py2.7.egg/EGG-INFO/PKG-INFO.

I would assert then that the test phase ought read

python_test() {
        nosetests || die
}

which then requires 

DEPEND+="dev-python/nose[${PYTHON_USEDEP}]" || "dev-python/pytest[${PYTHON_USEDEP}]", 
substitute  nosetests || die with py.test || die.

So 'someone' can commit at leisure and pleasure since my fingers aren't up to it.
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2013-07-30 12:11:55 UTC
This kind of package is exactly the reason that the OpenStack stuff should go in a different herd.
Comment 2 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-08-09 16:13:06 UTC
restricting tests now