Bug 478730 – dev-utils/schroot-1.6.5 USE=btrfs - configure should not fail when /sbin/btrfs* is not found

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alex Turbov 2013-07-30 05:00:14 UTC]

upstream has strange detection of prtfs-progs presence: configure.ac fails if there is no `btrfsctl' executable found. I don't know what is this, but there is no such binary in my system. moreover, that binary is not used actually by the `/etc/schroot/setup.d/05btrfs' script anyway.


Reproducible: Always

Steps to Reproduce:
1.USE=brtfs emerge schroot
2.configure script fails
3.



in attach there is a pathc for ebuild and configure.ac to fix that problem

[Comment 1 Alex Turbov 2013-07-30 05:01:04 UTC]

Created attachment 354584 [details]
schroot-1.6.5-r1.ebuild

[Comment 2 Alex Turbov 2013-07-30 05:02:29 UTC]

Created attachment 354586 [details, diff]
patch to fix schroot's configure

[Comment 3 Alex Turbov 2013-07-30 05:03:17 UTC]

Created attachment 354588 [details, diff]
patch to schroot-1.6.5.ebuild (make it -r1)

[Comment 4 Jeroen Roovers (RETIRED) 2013-07-30 13:01:31 UTC]

Comment on attachment 354584 [details]
schroot-1.6.5-r1.ebuild

--- schroot-1.6.5.ebuild        2013-03-10 20:39:27.961366292 +0100
+++ -   2013-07-30 15:01:25.252841663 +0200
@@ -49,6 +49,7 @@
 
 PATCHES=(
        "${FILESDIR}/${PN}-1.6.3-tests.patch"
+       "${FILESDIR}/${PN}-1.6.5-fix-btrfs-detection.patch"
 )
 
 src_unpack() {

[Comment 5 Jeroen Roovers (RETIRED) 2013-07-30 13:03:17 UTC]

Comment on attachment 354586 [details, diff]
patch to fix schroot's configure

Why stop there? It doesn't need to know about /sbin/btrfs at build time either.

[Comment 6 Jeroen Roovers (RETIRED) 2013-07-30 13:07:07 UTC]

Apparently you shouldn't even be seeing this configure failure, since sys-fs/btrfs-progs provides /sbin/btrfs{,ctl} and since that package is properly listed in dev-util/schroot's DEPEND. Now, whether it should be in DEPEND at all is another issue, but it's the one you ended up with. Did the btrfs-progs executables move to /usr/sbin recently?

[Comment 7 Alex Turbov 2013-07-30 13:33:11 UTC]

(In reply to Jeroen Roovers from comment #6)
> Apparently you shouldn't even be seeing this configure failure, since
> sys-fs/btrfs-progs provides /sbin/btrfs{,ctl} and since that package is
> properly listed in dev-util/schroot's DEPEND. Now, whether it should be in
> DEPEND at all is another issue, but it's the one you ended up with. Did the
> btrfs-progs executables move to /usr/sbin recently?

I don't know. Here is a list of executables from `btrfs-progs` I've got in my system:
root@gentop ~ # cave executables btrfs-progs
/sbin/mkfs.btrfs
/sbin/btrfs-debug-tree
/sbin/btrfsck
/sbin/btrfs
/sbin/btrfs-map-logical
/sbin/btrfs-image
/sbin/btrfs-zero-log
/sbin/btrfs-convert
/sbin/btrfs-find-root
/sbin/btrfstune
/sbin/btrfs-show-super

and there is no `btrfsctl`! (probaply it is smth outdated)

[Comment 8 Alex Turbov 2013-07-30 13:40:22 UTC]

(In reply to Jeroen Roovers from comment #5)
> Why stop there? It doesn't need to know about /sbin/btrfs at build time
> either.

Yeah, really... schroot do not use detected executable path anyway... as well as lvm binaries... So, I suppose it must be RDEPEND only (lvm2 and ptrfs-progs), but I've got some uncertain feeling about this solution, cuz it require to patch configure.ac (just remove few lines) and I'm in doubt that upstream will accept this patch... so we have to apply it for all future releases, which is (slightly) harder that doing just version bump :)

[Comment 9 Dennis Schridde 2014-01-12 11:34:38 UTC]

I just ran into this, too.

[Comment 10 Marcus van Dam 2014-06-25 07:32:24 UTC]

Confirmed that it cannot find `btrfsctl` in the latest version (~1.6.5-r1). Any plans on including a patch in the ebuild?

[Comment 11 Sergey Popov 2014-10-12 11:09:42 UTC]

*** Bug 524902 has been marked as a duplicate of this bug. ***

[Comment 12 Jonathan Callen (RETIRED) 2016-05-22 17:18:13 UTC]

This should have been fixed as of the latest stable, 1.6.10-r3.