Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478556 - sys-power/nut installs systemd files into /usr/usr
Summary: sys-power/nut installs systemd files into /usr/usr
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-29 10:12 UTC by Dmitry Derevyanko
Modified: 2013-08-12 18:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge_info,21.20 KB, text/plain)
2013-07-29 10:13 UTC, Dmitry Derevyanko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Derevyanko 2013-07-29 10:12:48 UTC
sys-power/nut installs own systemd service files into /usr/usr/lib64/systemd/system/ instead of /usr/lib64/systemd/system/
$ qlist sys-power/nut | grep -i systemd
/usr/usr/lib64/systemd/system/nut-monitor.service
/usr/usr/lib64/systemd/system/nut-driver.service
/usr/usr/lib64/systemd/system/nut-server.service
/usr/lib64/systemd/system-shutdown/nutshutdown

Reproducible: Always

Steps to Reproduce:
1. emerge sys-power/nut
2. qlist sys-power/nut | grep -i systemd
3.
Comment 1 Dmitry Derevyanko 2013-07-29 10:13:55 UTC
Created attachment 354488 [details]
emerge --info
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-07-29 10:27:10 UTC
configure --help: 
  --with-systemdsystemunitdir=DIR
                          Directory for systemd service files (auto)
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-07-29 10:46:53 UTC
Sounds like it goes nuts :).

configure.in:985

dnl Override installation directory, with the local installation
dnl prefix. This is needed for 'distcheck*' targets, otherwise
dnl files will try to get intalled to the actual system directories
if test -n "${systemdsystemunitdir}"; then
    systemdsystemshutdowndir="${libdir}/systemd/system-shutdown"
    AC_MSG_RESULT(using ${systemdsystemunitdir})
    systemdsystemunitdir="`echo ${systemdsystemunitdir} | sed 's/\/lib/\${libdir}/'`"
else
    AC_MSG_RESULT(no)
fi


This is what screws it up hard. It's basically using pkg-config then assuming it gave a pre-defined value. And they're using that to hack distcheck over...

Instead, they should add something like the following to Makefile.am's DISTCHECK_CONFIGURE_FLAGS (like they're doing e.g. for udev):

--with-systemdsystemunitdir=\$${libdir}/systemd/system


Would you proxy this upstream or shall we do it?
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2013-08-12 18:54:52 UTC
InCVS