Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 47853 - Updated ebuild for filelight-0.6.4-1
Summary: Updated ebuild for filelight-0.6.4-1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2004-04-14 15:52 UTC by Andrej Kacian (RETIRED)
Modified: 2004-05-25 17:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
A modified ebuild file for filelight (filelight-0.6.4.1-r1.ebuild,694 bytes, text/plain)
2004-04-14 15:52 UTC, Andrej Kacian (RETIRED)
Details
A modified ebuild for filelight (filelight-0.6.4.1-r1.ebuild,583 bytes, text/plain)
2004-04-14 17:36 UTC, Andrej Kacian (RETIRED)
Details
A fixed ebuild for filelight 0.6.4.1 (filelight-0.6.4.1-r1.ebuild,566 bytes, text/plain)
2004-04-16 10:31 UTC, Andrej Kacian (RETIRED)
Details
An ebuild file for filelight 0.6.4-1 (filelight-0.6.4.1-r1.ebuild,544 bytes, text/plain)
2004-04-17 10:15 UTC, Andrej Kacian (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Kacian (RETIRED) gentoo-dev 2004-04-14 15:52:09 UTC
The configure script for filelight supports --without-arts option, but the ebuild doesn't. See attached ebuild, which remedies this problem.

I am not sure if this is the right way:
This ebuild inherits kde-base, so it has kde_src_compile() already. I've written a replacement src_compile() function which takes "arts" USE flag into account. Is there any way to re-use the original kde_src_compile() and honor mentioned USE flag at once?
Comment 1 Andrej Kacian (RETIRED) gentoo-dev 2004-04-14 15:52:53 UTC
Created attachment 29291 [details]
A modified ebuild file for filelight
Comment 2 Carsten Lohrke (RETIRED) gentoo-dev 2004-04-14 17:02:56 UTC
- kde-base is deprecated, use kde instead
- the ebuild header is invalid:
http://www.gentoo.org/doc/en/ebuild-mistakes.xml
Comment 3 Andrej Kacian (RETIRED) gentoo-dev 2004-04-14 17:36:54 UTC
Created attachment 29296 [details]
A modified ebuild for filelight

Sorry about the header, I just copied and modified the existing ebuild.

I forgot to add that filielight works perfectly even when not using *_compile()
function from kde.eclass.
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2004-04-15 02:44:26 UTC
> I forgot to add that filielight works perfectly even when not using *_compile()
function from kde.eclass.

Oh, overlooked that. It will fail because of sandbox problems, when having userpriv in features. Please replace the econf/emake lines with "kde_src_compile all". Also the eclass sets a lot of other options, so it isn't acceptable not to use the inherited function, when inheriting the kde.eclass.
Comment 5 Andrej Kacian (RETIRED) gentoo-dev 2004-04-15 08:31:17 UTC
That's what I've been asking in my original comment for this bug - how to honor "arts" USE flag and use functions from kde.eclass at the same time?
Comment 6 Carsten Lohrke (RETIRED) gentoo-dev 2004-04-15 11:01:39 UTC
Just set myconf as you like and call "kde_src_compile all" afterwards. The function appends a few other options, but doesn't overwrite myconf.
Comment 7 Andrej Kacian (RETIRED) gentoo-dev 2004-04-16 10:31:09 UTC
Created attachment 29431 [details]
A fixed ebuild for filelight 0.6.4.1

Thanks for the advice, I now know how to re-use inherited functions :)
Comment 8 Andrej Kacian (RETIRED) gentoo-dev 2004-04-17 09:03:19 UTC
I forgot to write, that I have included an usable (hopefully) version of ebuild.
Comment 9 Carsten Lohrke (RETIRED) gentoo-dev 2004-04-17 09:40:39 UTC
A few annotations Andrej: 
- just remove the '&& myconf="${myconf}"' part
- the devs probably wouldn't consider this a -r1, but a silent ebuild update (i could be wrong, though)
- don't lose patience, sometimes these minor ebuild fixes need a while until they get commited
Comment 10 Andrej Kacian (RETIRED) gentoo-dev 2004-04-17 10:15:11 UTC
Created attachment 29506 [details]
An ebuild file for filelight 0.6.4-1

Thanks for suggestions, I've fixed the ebuild according to the first one. Let
devs express their opinion about the ebuild name.
Comment 11 Donovan Long 2004-05-18 21:23:06 UTC
A great program, very handy.  Apr 17th ebuild works perfectly, ready for portage?
Comment 12 Andrej Kacian (RETIRED) gentoo-dev 2004-05-20 11:16:50 UTC
Yes, pretty ready, I think. We've straightened out all quirks by now.
Comment 13 Caleb Tennis (RETIRED) gentoo-dev 2004-05-25 17:03:14 UTC
committed - thanks for ebuild.