Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478466 - dev-php/pecl-event - PHP wrapper for dev-libs/libevent-2
Summary: dev-php/pecl-event - PHP wrapper for dev-libs/libevent-2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Ruslan Osmanov
URL: http://pecl.php.net/package/event
Whiteboard:
Keywords: EBUILD, InVCS
Depends on:
Blocks:
 
Reported: 2013-07-28 13:02 UTC by Ruslan Osmanov
Modified: 2013-09-22 09:40 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pecl-event-1.7.2.ebuild (pecl-event-1.7.2.ebuild,1.01 KB, text/plain)
2013-07-28 13:02 UTC, Ruslan Osmanov
Details
pecl-event-1.7.2.ebuild (pecl-event-1.7.2.ebuild,1.01 KB, text/plain)
2013-07-28 13:07 UTC, Ruslan Osmanov
Details
pecl-event-1.7.8.ebuild (pecl-event-1.7.8.ebuild,979 bytes, text/plain)
2013-09-19 19:37 UTC, Ruslan Osmanov
Details
pecl-event-1.7.8.ebuild (pecl-event-1.7.8.ebuild,921 bytes, text/plain)
2013-09-19 19:57 UTC, Ruslan Osmanov
Details
pecl-event-1.7.8.ebuild (pecl-event-1.7.8.ebuild,985 bytes, text/plain)
2013-09-19 20:20 UTC, Ruslan Osmanov
Details
pecl-event-1.7.8.ebuild (pecl-event-1.7.8.ebuild,918 bytes, text/plain)
2013-09-20 05:39 UTC, Ruslan Osmanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Osmanov 2013-07-28 13:02:08 UTC
Created attachment 354396 [details]
pecl-event-1.7.2.ebuild

Please add attached pecl-event-1.7.2.ebuild file to the portage tree: dev-php/pecl-event.

Thanks.
Comment 1 Ruslan Osmanov 2013-07-28 13:07:14 UTC
Created attachment 354398 [details]
pecl-event-1.7.2.ebuild

Sorry, the previous pecl-event-1.7.2.ebuild file is incorrect. Some of USE flag defaults were assigned incorrectly.

Attached a correct ebuild.
Comment 2 Ruslan Osmanov 2013-08-14 11:35:30 UTC
I've just uploaded 1.7.4 version to PECL. So the file should be renamed to pecl-event-1.7.4.ebuild.
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2013-09-19 19:17:12 UTC
The ebuild is not correct. You call insinto in src_install but you never call doins so nothing actually is installed in ${PHP_EXT_SHARED_DIR}. Could you also fix the postinst message ? What is installed in that directory?
Comment 4 Ruslan Osmanov 2013-09-19 19:37:19 UTC
Created attachment 359054 [details]
pecl-event-1.7.8.ebuild

Indeed, there was no need in PHP_EXT_SHARED_DIR.

Event version 1.7.8 introduces --enable-event-sockets configure option.
So I've attached new ebuild.
Comment 5 Ruslan Osmanov 2013-09-19 19:47:17 UTC
Probably there should be used common USE-flags, e.g.:
threads for --enable-event-pthreads
ssl for --enable-event-openssl

(If there was "extra" flag in /usr/portage/profiles/use.desc, I'd used it for --enable-event-extra)
Comment 6 Ruslan Osmanov 2013-09-19 19:57:02 UTC
Created attachment 359056 [details]
pecl-event-1.7.8.ebuild

Replaced event_* USE-flags with common USE-flag names:
ssl for --enable-event-openssl
threads for --enable-event-pthreads
sockets for --enable-event-sockets

also
extra for --enable-event-extra
Comment 7 Ruslan Osmanov 2013-09-19 20:04:36 UTC
Sorry for being annoying, but I forgot to mention that --enable-event-sockets
implies dependency on PHP's sockets extension. Namely, --enable-event-sockets
actually requires PHP's --enable-sockets, while --disable-event-sockets turns off this requirement. 

Don't know how it is written in ebuild.
Comment 8 Ruslan Osmanov 2013-09-19 20:20:24 UTC
Created attachment 359058 [details]
pecl-event-1.7.8.ebuild

Ah, I've just learnt about reverce deps. Attached new version.
Again, sorry for being annoying. I'm turning off.
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2013-09-19 20:37:29 UTC
(In reply to Ruslan Osmanov from comment #8)
> Created attachment 359058 [details]
> pecl-event-1.7.8.ebuild
> 
> Ah, I've just learnt about reverce deps. Attached new version.
> Again, sorry for being annoying. I'm turning off.

src_install() {
	php-ext-pecl-r2_src_install
}

Why are you doing that? php-ext-pecl-r2_src_install will be the default install since the php-ext-pecl-r2 eclass that you inherit is the only eclass that exports an src_install function
Comment 10 Ruslan Osmanov 2013-09-20 05:39:39 UTC
Created attachment 359102 [details]
pecl-event-1.7.8.ebuild

Removed unnecessary src_install. Added "examples" USE-flag, since the package has "examples" directory.
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2013-09-21 23:59:27 UTC
Please run repoman full when you develop an ebuild. You need to properly define  the "extras" use flag in metadata.xml. Could you give me a proper description of that flag so I can add it to metadata.xml?

RepoMan scours the neighborhood...
>>> Creating Manifest for /home/hwoarang/development/gentoo-cvs/gentoo-x86/dev-php/pecl-event
  IUSE.invalid                  1
   dev-php/pecl-event/pecl-event-1.7.8.ebuild: extra
Comment 12 Ruslan Osmanov 2013-09-22 07:48:42 UTC
(In reply to Markos Chandras from comment #11)
> Please run repoman full when you develop an ebuild. You need to properly
> define  the "extras" use flag in metadata.xml. Could you give me a proper
> description of that flag so I can add it to metadata.xml?
> 
> RepoMan scours the neighborhood...
> >>> Creating Manifest for /home/hwoarang/development/gentoo-cvs/gentoo-x86/dev-php/pecl-event
>   IUSE.invalid                  1
>    dev-php/pecl-event/pecl-event-1.7.8.ebuild: extra

I don't know how to checkout the portage anonymously, so I can't use repoman.

The "extra" USE-flag means support of the Libevent extra API. The dev-libs/libevent package has no USE-flag for choosing whether libevent_extra library has to be installed, although it is actually optional:
http://www.wangafu.net/~nickm/libevent-book/Ref0_meta.html#_the_libraries

If dev-libs/libevent package had a USE-flag for the optional libevent_extra library, I would provide corresponding dependency in dev-php/pecl-event. Probably we should add such a flag for dev-libs/libevent enabled by default, then make use of it in the PECL package.

P.S.
In similar bug(dev-php/pecl-eio) you wrote that I shouldn't bother with "Assigned To" field. Sorry, I didn't understand what you meant.
Comment 13 Ole Markus With (RETIRED) gentoo-dev 2013-09-22 09:30:54 UTC
(In reply to Ruslan Osmanov from comment #12)

> I don't know how to checkout the portage anonymously, so I can't use repoman.
 
repoman works in overlays too.

> The "extra" USE-flag means support of the Libevent extra API. The
> dev-libs/libevent package has no USE-flag for choosing whether
> libevent_extra library has to be installed, although it is actually optional:
> http://www.wangafu.net/~nickm/libevent-book/Ref0_meta.html#_the_libraries
> 

If the USE flag do not notably grow the binary size, change the behaviour or add additional dependencies, there is no need to add a USE flag for it. Just always compile it in.

> P.S.
> In similar bug(dev-php/pecl-eio) you wrote that I shouldn't bother with
> "Assigned To" field. Sorry, I didn't understand what you meant.

He meant that you should not change the assigned-to field. Just let the bug be assigned to you
Comment 14 Markos Chandras (RETIRED) gentoo-dev 2013-09-22 09:40:43 UTC
Committed with the necessary changes. Thanks

+*pecl-event-1.7.8 (22 Sep 2013)
+
+  22 Sep 2013; Markos Chandras <hwoarang@gentoo.org> +metadata.xml,
+  +pecl-event-1.7.8.ebuild:
+  Initial commit. Ebuild by Ruslan Osmanov <rrosmanov@gmail.com>. He will also
+  be the maintainer. Bug #478466