Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 47842 - Gaim patch for better Hebrew support
Summary: Gaim patch for better Hebrew support
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gaim Bugs Crew
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-14 14:11 UTC by Ohad Lutzky
Modified: 2004-04-15 07:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Newline patch for gaim 0.76 (gaim-0.76-newline.diff,1.06 KB, patch)
2004-04-14 14:11 UTC, Ohad Lutzky
Details | Diff
Ebuild using aforementioned patch (gaim-0.76-r3.ebuild,3.63 KB, application/octet-stream)
2004-04-14 14:12 UTC, Ohad Lutzky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ohad Lutzky 2004-04-14 14:11:10 UTC
Since GTK 2.4 came out, Hebrew (bidi, that is) support has much improved in gaim. Since it determines the direction of the paragraph based on its first letter, it has become useful to have the text of each message be on a separate line than the nickname. I have created a patch that adds an option to do this in the Message Text preferences menu.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Ohad Lutzky 2004-04-14 14:11:52 UTC
Created attachment 29286 [details, diff]
Newline patch for gaim 0.76
Comment 2 Ohad Lutzky 2004-04-14 14:12:28 UTC
Created attachment 29287 [details]
Ebuild using aforementioned patch

Based on gaim-0.76-r2.ebuild
Comment 3 Don Seiler (RETIRED) gentoo-dev 2004-04-14 17:39:26 UTC
Can I ask where you got this patch?  I like to know where these things come from because I discuss them upstream as well.
Comment 4 Ohad Lutzky 2004-04-15 00:05:22 UTC
I wrote it myself, actually :)
If this is about credit, a guy called Ilan Tanny helped me find where to put the settings. But no, I didn't grab it off a newsletter or anything... I've also submitted patches to the gaim sourceforge project (as a feature request), but it'll take them years to look at it.
Comment 5 Don Seiler (RETIRED) gentoo-dev 2004-04-15 07:14:19 UTC
I don't believe it is a good idea to add patches that aren't upstream CVS.  The problem is that then the distro ends up supporting the patch and will keep re-patching for every release.  I'm leaning towards ending support for the CJK patch for this very reason.

If/when your patch is accepted upstream, feel free to re-open this bug and paste the URL to the patch tracker entry.