Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478234 - app-emulation/xen-tools-4.2.2-r3 USE=screen - xendomains conf.d script contains duplicate AUTODIR and PARALLEL_SHUTDOWN entries
Summary: app-emulation/xen-tools-4.2.2-r3 USE=screen - xendomains conf.d script contai...
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Delaney (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-26 13:22 UTC by Tomáš Mózes
Modified: 2013-07-30 10:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2013-07-26 13:22:42 UTC
The current stable xen-tools 4.2.2-r3 ebuild contains:

newconfd "${FILESDIR}"/xendomains.confd xendomains
if use screen; then
	cat "${FILESDIR}"/xendomains-screen.confd >> "${ED}"/etc/conf.d/xendomains || die
	cp "${FILESDIR}"/xen-consoles.logrotate "${ED}"/etc/xen/ || die
	keepdir /var/log/xen-consoles
fi

% cat xendomains.confd 
# /etc/conf.d/xendomains

# Directory of domains to boot. AUTODIR should contain one or more symlinks
# to domain config files in /etc/xen
AUTODIR=/etc/xen/auto

# Send shutdown commands to all domains in parallel instead of waiting for
# each to shutdown individually
PARALLEL_SHUTDOWN=yes


% cat xendomains-screen.confd 
# /etc/conf.d/xendomains

# Directory of domains to boot. AUTODIR should contain one or more symlinks
# to domain config files in /etc/xen
AUTODIR=/etc/xen/auto

# Send shutdown commands to all domains in parallel instead of waiting for
# each to shutdown individually
PARALLEL_SHUTDOWN=yes

# When SCREEN="yes", domains in AUTODIR have their consoles connected to a
# screen session named SCREEN_NAME, with output logged to individual files 
# named after each domain and written to /var/log/xen-consoles/ . These files
# are rotated (using app-admin/logrotate) every time xendomains is started.

SCREEN="yes"
SCREEN_NAME="xen"

# Number of seconds between writes to screen's logfiles.
#
# Lower values mean more disk activity and hence a possible performance
# impact, but higher values mean a greater chance of loosing some output
# in the event of a crash.

SCREEN_LOG_INTERVAL="1"


So if you build with screen, your conf.d ends up having AUTODIR and PARALLEL_SHUTDOWN twice.
Comment 1 Tomáš Mózes 2013-07-26 13:32:16 UTC
I suppose it would be sufficient to keep the general and screen only configuration separate - for example to remove:

# /etc/conf.d/xendomains

# Directory of domains to boot. AUTODIR should contain one or more symlinks
# to domain config files in /etc/xen
AUTODIR=/etc/xen/auto

# Send shutdown commands to all domains in parallel instead of waiting for
# each to shutdown individually
PARALLEL_SHUTDOWN=yes

from xendomains-screen.confd
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2013-07-30 10:15:44 UTC
(In reply to Tomas Mozes from comment #1)
> I suppose it would be sufficient to keep the general and screen only
> configuration separate - for example to remove:
> 
> # /etc/conf.d/xendomains
> 
> # Directory of domains to boot. AUTODIR should contain one or more symlinks
> # to domain config files in /etc/xen
> AUTODIR=/etc/xen/auto
> 
> # Send shutdown commands to all domains in parallel instead of waiting for
> # each to shutdown individually
> PARALLEL_SHUTDOWN=yes
> 
> from xendomains-screen.confd

Let's try it;

  30 Jul 2013; Ian Delaney <idella4@gentoo.org> files/xendomains-screen.confd:
  Take out duplicate AUTODIR && PARALLEL_SHUTDOWN from xendomains-screen.confd
  wrt Bug #478234