477880 – app-emulation/xen-tools-4.3.0 - pygrub is built despite USE=-pygrub

Bug 477880 - app-emulation/xen-tools-4.3.0 - pygrub is built despite USE=-pygrub

Summary: app-emulation/xen-tools-4.3.0 - pygrub is built despite USE=-pygrub

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Ian Delaney (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-07-23 09:29 UTC by Another Mortal
Modified:	2013-07-24 05:16 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Another Mortal 2013-07-23 09:29:36 UTC

The Makefile has changed.  The corresponding sed expression should be updated.

        if ! use pygrub; then
-               sed -e '/^SUBDIRS-$(PYTHON_TOOLS) += pygrub$/d' -i tools/Makefile || die
+               sed -e '/^SUBDIRS-y += pygrub$/d' -i tools/Makefile || die
        fi


I'd also like to suggest a 'python' USE flag (yes, really ;-))
with (at least) the following snippet in the build:

    if ! use python; then
        sed -e '/^SUBDIRS-y += python$/d' -i tools/Makefile || die
    fi


Reproducible: Always

Comment 1 Ian Delaney (RETIRED) gentoo-dev

2013-07-24 05:16:01 UTC

right, I wonder why the die didn't die.
Let's try out the python use flag and see how everyone likes it.


  24 Jul 2013; Ian Delaney <idella4@gentoo.org> xen-tools-4.3.0.ebuild:
  correct tools' Makefile re IUSE pygrub, add python use flag and corresponding
  sed to Makefile, fixes Bug #477880 by 'a.m'