Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 477716 - dev-ruby/rack-protection invalid slot number
Summary: dev-ruby/rack-protection invalid slot number
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 10:21 UTC by Anton Bolshakov
Modified: 2013-07-23 06:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2013-07-22 10:21:03 UTC
the current slot is SLOT="$(get_version_component_range 1)"

which makes all 1.3 1.4 and 1.5 versions be in the same slot.
Please fix it to the proper:

SLOT="$(get_version_component_range 1-2)"
Comment 1 Hans de Graaff gentoo-dev Security 2013-07-22 17:52:15 UTC
(In reply to Anton Bolshakov from comment #0)
> the current slot is SLOT="$(get_version_component_range 1)"
> 
> which makes all 1.3 1.4 and 1.5 versions be in the same slot.

As they should be.

> Please fix it to the proper:

Why is that proper? What is the specific problem that you have?
Comment 2 Anton Bolshakov 2013-07-22 21:20:46 UTC
I'm writing 2 ebuilds for Pentoo overlay and they require two different version of rock-protection. The same goes to dev-ruby/sinatra (it's not slotted at all)

I've look through other dev-ruby/* ebuilds and they all use "get_version_component_range 1-2".

The current "range 1" is pretty much pointless, you can just use slot=0 or adjust it as I suggested.
Comment 3 Hans de Graaff gentoo-dev Security 2013-07-23 04:52:54 UTC
(In reply to Anton Bolshakov from comment #2)
> I'm writing 2 ebuilds for Pentoo overlay and they require two different
> version of rock-protection. The same goes to dev-ruby/sinatra (it's not
> slotted at all)

Sinatra 1..3 has 'rack-protection', '~> 1.2', meaning, in Gentoo terms ">=dev-ruby/rack-protection-1.2 =dev-ruby/rack-protection-1*". Or rather: ">=dev-ruby/rack-protection-1.2:1", as we have it.

> I've look through other dev-ruby/* ebuilds and they all use
> "get_version_component_range 1-2".

We assume semantic versioning unless specifically indicated otherwise. It's not relevant what slotting mechanism other packages have. rubygems unfortunately does not require a specific API/ABI compatibility scheme, so we have to determine this package by package.

> The current "range 1" is pretty much pointless, you can just use slot=0 or
> adjust it as I suggested.

No, SLOT=1 is relevant here, see the sinatra dependency.
Comment 4 Anton Bolshakov 2013-07-23 05:17:15 UTC
(In reply to Hans de Graaff from comment #3)

> Sinatra 1..3 has 'rack-protection', '~> 1.2', meaning, in Gentoo terms
> ">=dev-ruby/rack-protection-1.2 =dev-ruby/rack-protection-1*". Or rather:
> ">=dev-ruby/rack-protection-1.2:1", as we have it.
> 

that pulls rack-protection-1.5.0 which is wrong

The same goes to sinatra 1.4 which requires rack-protection ~> 1.4 and not 1.5
Comment 5 Hans de Graaff gentoo-dev Security 2013-07-23 06:23:47 UTC
(In reply to Anton Bolshakov from comment #4)
> (In reply to Hans de Graaff from comment #3)
> 
> > Sinatra 1..3 has 'rack-protection', '~> 1.2', meaning, in Gentoo terms
> > ">=dev-ruby/rack-protection-1.2 =dev-ruby/rack-protection-1*". Or rather:
> > ">=dev-ruby/rack-protection-1.2:1", as we have it.
> > 
> 
> that pulls rack-protection-1.5.0 which is wrong
> 
> The same goes to sinatra 1.4 which requires rack-protection ~> 1.4 and not
> 1.5

If you don't take my word for it, then please check http://docs.rubygems.org/read/chapter/16#page74

It's now clear to me that this bug is in fact invalid, marking it as such.