Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 477174 - mail-client/mutt-1.5.21-r12 - sidebar does not correctly align the number of letters in the box, if the box name contains multibyte UTF-8 characters
Summary: mail-client/mutt-1.5.21-r12 - sidebar does not correctly align the number of ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on:
Blocks:
 
Reported: 2013-07-17 07:06 UTC by Alexandr Darkman
Modified: 2014-03-09 11:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
correct printw format string in sidebar.c/draw_sidebar (sidebar-utf8-printw.patch,723 bytes, patch)
2013-07-17 07:11 UTC, Alexandr Darkman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandr Darkman 2013-07-17 07:06:34 UTC
Sidebar do not aligns correctly the number of letters in the box, if the box name contains multibyte UTF-8 characters. (Russian, for example.) 
 


Reproducible: Always

Steps to Reproduce:
env USE="sidebar" emerge mutt

create maildir with long (about 8 characters) multibyte UTF-8 name, and put some mails in.

In .muttrc:
1. place long multibyte UTF-8 box name in 'mailboxes'
2. 'set sidebar_visible = yes'
3. 'set sidebar_width = 25'

run mutt

Actual Results:  
number of letters in the box not properly aligned/not visible

Expected Results:  
number of letters correctly left aligned

Portage 2.1.11.62 (default/linux/amd64/13.0/desktop, gcc-4.6.3, glibc-2.15-r3, 3.7.10-gentoo x86_64)
=================================================================
System uname: Linux-3.7.10-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T5870_@_2.00GHz-with-gentoo-2.2
KiB Mem:     3087376 total,   1181356 free
KiB Swap:    1951860 total,   1951860 free
Timestamp of tree: Wed, 05 Jun 2013 12:00:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p45
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.6.8-r1, 2.7.3-r3, 3.1.3-r1, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.5-r1, 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.6, 1.12.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            3.4.6-r2, 4.4.7, 4.5.4, 4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo ROKO__ enlightenment
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA dlj-1.1 skype-eula AdobeFlash-10 Oracle-BCLA-JavaSE AdobeFlash-10.3 AdobeFlash-11.x"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/polkit-1/actions /var/bind /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://91.121.125.139/gentoo-distfiles/ http://mirror.qubenet.net/mirror/gentoo/ rsync://gentoo.bloodhost.ru/gentoo-distfiles ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo rsync://gentoo.lcc.ufmg.br/gentoo-sources"
LANG="ru_RU.UTF-8"
LC_ALL="ru_RU.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/ROKO__ /var/lib/layman/enlightenment"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr chm cli consolekit cracklib crypt cscope cups cxx dbus djvu dri dts dvd dvdr emboss encode exif fam firefox flac fortran ftp gdbm gif gpg gpm gtk hscolour iconv jpeg kde kipi laptop lcms ldap libnotify lzma mad md5sum mmx mng modules mp3 mp4 mpeg mplayer mudflap multilib ncurses nls nptl odbc ogg opengl openmp pam pango pcre pdf png policykit postgres ppds qt3support qt4 readline samba sdl semantic-desktop session spell sse sse2 ssl startup-notification svg syntax tcpd thumbnail tiff truetype udev udisks unicode upower usb utils v4l vim vim-syntax vorbis wxwidgets x264 xcb xcomposite xft xinerama xml xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="prefork" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="synaptics mouse keyboard evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en ru ru_RU" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_6" PYTHON_TARGETS="python3_2 python2_6" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nv vesa v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Alexandr Darkman 2013-07-17 07:11:44 UTC
Created attachment 353484 [details, diff]
correct printw format string in sidebar.c/draw_sidebar
Comment 2 Fabian Groffen gentoo-dev 2013-09-09 20:00:16 UTC
It's not as easy as just dropping the limit, that'll cause misalignment if the mailbox name is longer than sidebarwidth.
Comment 3 Alexandr Darkman 2013-09-10 08:50:45 UTC
(In reply to Fabian Groffen from comment #2)
> It's not as easy as just dropping the limit, that'll cause misalignment if
> the mailbox name is longer than sidebarwidth.

It's not cause misalignment because alignment is done earlier in the call chain.
In sidebar-utf8.patch -> make_sidebar_entry
Comment 4 Fabian Groffen gentoo-dev 2013-09-18 07:32:49 UTC
(In reply to Alexandr Darkman from comment #3)
> (In reply to Fabian Groffen from comment #2)
> > It's not as easy as just dropping the limit, that'll cause misalignment if
> > the mailbox name is longer than sidebarwidth.
> 
> It's not cause misalignment because alignment is done earlier in the call
> chain.
> In sidebar-utf8.patch -> make_sidebar_entry

ok, then your patch should be easy and correct.
Comment 5 Fabian Groffen gentoo-dev 2014-03-09 11:50:41 UTC
IIRC this patch should be in 1.5.22-r2