Bug 476166 – dev-python/libnatpmp-20120821-r1 distutils-r1 conversion

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ian Delaney (RETIRED) 2013-07-08 10:13:20 UTC]

~/cvsPortage/gentoo-x86/dev-python/libnatpmp $ ebuild libnatpmp-20120821-r1.ebuild clean install

running install_egg_info
Writing /mnt/gen2/TmpDir/portage/dev-python/libnatpmp-20120821-r1/image//_pypy-c2.0/usr/lib64/pypy2.0/site-packages/libnatpmp-1.0-py2.7.egg-info
 * python2_7: running distutils-r1_run_phase distutils-r1_python_install_all
>>> Completed installing libnatpmp-20120821-r1 into /mnt/gen2/TmpDir/portage/dev-python/libnatpmp-20120821-r1/image/

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   usr/lib64/python2.6/site-packages/libnatpmp.so
   usr/lib64/python2.5/site-packages/libnatpmp.so
   usr/lib64/python2.7/site-packages/libnatpmp.so
   usr/lib64/pypy2.0/site-packages/libnatpmp.pypy-20.so

~/cvsPortage/gentoo-x86/dev-python/libnatpmp $ diff -u libnatpmp-20120821.ebuild libnatpmp-20120821-r1.ebuild
--- libnatpmp-20120821.ebuild	2012-08-27 08:50:36.000000000 +0800
+++ libnatpmp-20120821-r1.ebuild	2013-07-08 18:08:05.972798954 +0800
@@ -1,12 +1,11 @@
-# Copyright 1999-2012 Gentoo Foundation
+# Copyright 1999-2013 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-python/libnatpmp/libnatpmp-20120821.ebuild,v 1.1 2012/08/27 00:50:36 blueness Exp $
+# $Header: $
 
-EAPI=3
-PYTHON_DEPEND=2
-RESTRICT_PYTHON_ABIS="3.*"
+EAPI=5
+PYTHON_COMPAT=( python{2_5,2_6,2_7} pypy2_0 )
 
-inherit eutils distutils
+inherit distutils-r1
 
 DESCRIPTION="Python module for libnatpmp, an alternative protocol to UPnP IGD."
 HOMEPAGE="http://miniupnp.free.fr/libnatpmp.html"
@@ -17,13 +16,13 @@
 KEYWORDS="~amd64 ~x86"
 IUSE=""
 
-DEPEND="=net-libs/${PF}"
+DEPEND="=net-libs/${P}"
 RDEPEND="${DEPEND}"
 
-src_prepare() {
+python_prepare_all() {
 	epatch "${FILESDIR}"/link-against-system-lib.patch
-	distutils_src_prepare
 
 	#These are installed by net-libs/libnatpmp
 	rm -f Changelog.txt README || die
+	distutils-r1_python_prepare_all
 }

[Comment 1 Anthony Basile 2013-07-09 00:15:29 UTC]

Its committed without rev bump.  Why force people following ~arch to recompile?

[Comment 2 Mike Gilbert 2013-07-09 00:43:20 UTC]

(In reply to Anthony Basile from comment #1)
> Its committed without rev bump.  Why force people following ~arch to
> recompile?

I'm not sure an in-place eapi change is a good idea. 

Also the set of installed files has changed since we compile the python modules in src_install.

[Comment 3 Anthony Basile 2013-07-09 01:05:29 UTC]

(In reply to Mike Gilbert from comment #2)
> (In reply to Anthony Basile from comment #1)
> > Its committed without rev bump.  Why force people following ~arch to
> > recompile?
> 
> I'm not sure an in-place eapi change is a good idea. 
> 
> Also the set of installed files has changed since we compile the python
> modules in src_install.

Okay I restored the old one and rev bumped.  Should be okay since on a few minutes passed.