Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 475282 - =media-video/bdsup2sub-5.1.2 - Version bump + Correct upstream site / metadata
Summary: =media-video/bdsup2sub-5.1.2 - Version bump + Correct upstream site / metadata
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Media-video project
URL: https://github.com/mjuhasz/BDSup2Sub/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-30 04:47 UTC by BT
Modified: 2016-11-22 00:15 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bdsup2sub-5.1.2.ebuild incomplete ebuild (file_475282.txt,813 bytes, text/plain)
2014-04-25 17:13 UTC, Steve Dibb (RETIRED)
Details
bdsup2sub-5.1.2.ebuild (bdsup2sub-5.1.2.ebuild,814 bytes, text/plain)
2014-04-28 06:25 UTC, BT
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2013-06-30 04:47:58 UTC
The development of bdsup2sub appears to have a new maintainer (see bug url). The old site has had no updates for 3+ years.

Would it be possible to have this package updated to use the current site/maintainer?
Comment 1 José Romildo Malaquias 2014-04-25 14:02:16 UTC
Version 5.1.2 has already been released.

From the news page https://github.com/mjuhasz/BDSup2Sub/wiki/News:

Version 5.1.2

Saturday, December 28, 2013

BDSup2Sub 5.1.2 has been released. This is a bugfix release that fixes a previously ignored command line option and the progress bar window not disappearing after reaching 100%.

    Fixed: --scale command line option ignored
    Fixed: progress bar window remains open under certain conditions
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2014-04-25 15:52:42 UTC
(In reply to José Romildo Malaquias from comment #1)
> Version 5.1.2 has already been released.
> 
> From the news page https://github.com/mjuhasz/BDSup2Sub/wiki/News:
> 
> Version 5.1.2
> 
> Saturday, December 28, 2013
> 
> BDSup2Sub 5.1.2 has been released. This is a bugfix release that fixes a
> previously ignored command line option and the progress bar window not
> disappearing after reaching 100%.
> 
>     Fixed: --scale command line option ignored
>     Fixed: progress bar window remains open under certain conditions

José,

Thanks for the notice.

This new version is packaged with a .deb file that has the desktop icon and .desktop file with it, while the other is just(?) the jar file.

I'm not familiar with how Debian packages are unpacked in portage, so, if someone wants to make an ebuild, go for it.
Comment 3 Steve Dibb (RETIRED) gentoo-dev 2014-04-25 17:13:46 UTC
Created attachment 375706 [details]
bdsup2sub-5.1.2.ebuild incomplete ebuild

Incomplete ebuild
Comment 4 Steve Dibb (RETIRED) gentoo-dev 2014-04-25 17:15:57 UTC
(In reply to Steve Dibb from comment #3)
> Created attachment 375706 [details]
> bdsup2sub-5.1.2.ebuild incomplete ebuild
> 
> Incomplete ebuild

I managed to hack this together, but it still needs some work.

This ebuild installs the jar file to /usr/share/bdsup2sub/lib/bdsup2sub.jar, but when running the program it looks for it at /usr/lib/bdsup2sub/bdsup2sub.jar

Not sure how to fix. :T
Comment 5 BT 2014-04-28 02:19:40 UTC
(In reply to Steve Dibb from comment #4)
> This ebuild installs the jar file to /usr/share/bdsup2sub/lib/bdsup2sub.jar,
> but when running the program it looks for it at
> /usr/lib/bdsup2sub/bdsup2sub.jar
> 
> Not sure how to fix. :T

I believe this is the result of installing a pre-built jar file, which has been built with a different prefix. Looking at pom.xml, there is the following entry:

<prefix>/usr/lib/bdsup2sub</prefix>

The 4.0.0 ebuild actually builds the package from source using a custom build file, build.xml. Maybe we need to do the same for 5.1.2?
Comment 6 BT 2014-04-28 03:36:14 UTC
Since bdsup2sub-5.1.2 uses Maven, I'm not sure if we can package it from source. bdsup2sub-5.1.2 requires additional dependencies (defined in pom.xml) that are handled by Maven. Without a Maven eclass, this would be impossible/very difficult.
Comment 7 BT 2014-04-28 06:25:40 UTC
Created attachment 375928 [details]
bdsup2sub-5.1.2.ebuild

- Bumped minimum required jre/jdk to 1.7. The author states on the wiki that OpenJDK 6 is not supported, although Oracle JRE 6 should work. BDSup2Sub will start with icedtea-bin-1.6 but will crash when loading a sup file.
- Dropped app-arch/xz-utils dependency.
- Added LGPL-3 to LICENSE.
Comment 8 BT 2014-04-28 06:38:46 UTC
(In reply to BT from comment #7)
> Created attachment 375928 [details]
> bdsup2sub-5.1.2.ebuild

I'm not sure about java-pkg_dolauncher usage. There doesn't seem to be any documentation. I just used the java-pkg_dolauncher line from the 4.0.0 ebuild and modified the --main argument.

@Steve

The reason why the program was looking for it at /usr/lib/bdsup2sub/bdsup2sub.jar is that the wrapper script that you installed via dobin has the following.

exec java -Dwrapper -jar /usr/lib/bdsup2sub/bdsup2sub.jar "$@"

I guess we could just sed the correct location, but I decided to use java-pkg_dolauncher since that's appears to be the Gentoo way.
Comment 9 BT 2014-05-16 06:00:22 UTC
I've come across some blu-ray subtitles that work with 5.x but not 4.x and vice versa. Because of this I would prefer that the 4.x package remain in Portage once the 5.x package gets added.
Comment 10 Steve Dibb (RETIRED) gentoo-dev 2014-08-22 18:42:35 UTC
(In reply to BT from comment #8)
> (In reply to BT from comment #7)
> > Created attachment 375928 [details]
> > bdsup2sub-5.1.2.ebuild
> 
> I'm not sure about java-pkg_dolauncher usage. There doesn't seem to be any
> documentation. I just used the java-pkg_dolauncher line from the 4.0.0
> ebuild and modified the --main argument.
> 
> @Steve
> 
> The reason why the program was looking for it at
> /usr/lib/bdsup2sub/bdsup2sub.jar is that the wrapper script that you
> installed via dobin has the following.
> 
> exec java -Dwrapper -jar /usr/lib/bdsup2sub/bdsup2sub.jar "$@"
> 
> I guess we could just sed the correct location, but I decided to use
> java-pkg_dolauncher since that's appears to be the Gentoo way.

Yah, just using sed seems like the easiest way to do it.
Comment 11 Steve Dibb (RETIRED) gentoo-dev 2014-08-22 18:47:26 UTC
(In reply to BT from comment #9)
> I've come across some blu-ray subtitles that work with 5.x but not 4.x and
> vice versa. Because of this I would prefer that the 4.x package remain in
> Portage once the 5.x package gets added.

A quick glance at the doom thread seems to indicate you're not the only one.

http://forum.doom9.org/showthread.php?t=145277

Also, note to self, may be a good idea to mirror the deb files ourselves since they're attached to a personal dropbox download.
Comment 12 Steve Dibb (RETIRED) gentoo-dev 2014-08-22 20:33:37 UTC
Fixing the path in the file works, but now I've got a new problem.  Running the program only brings up a blank window. -_-
Comment 13 BT 2014-08-23 01:07:22 UTC
(In reply to Steve Dibb from comment #12)
> Fixing the path in the file works, but now I've got a new problem.  Running
> the program only brings up a blank window. -_-

Make sure that you are using icedtea-7 or oracle-jre-1.7. icedtea-6 isn't supported. See comment #7.
Comment 14 BT 2016-11-17 01:22:43 UTC
If there are no objections I will close this bug since it's very unlikely that it will be fixed. In any case we now have media-video/bdsup2sub++, which is a c++ port of the original bdsup2sub. No more Java!