Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 474780 - net-dialup/gtkterm-0.99.5 - segmentation fault when sending hexadecimal data
Summary: net-dialup/gtkterm-0.99.5 - segmentation fault when sending hexadecimal data
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-06-25 22:46 UTC by Robert Pearce
Modified: 2016-08-25 19:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that fixes the bug (gtkterm-0.99.5-send-hex.patch,667 bytes, patch)
2013-06-25 22:47 UTC, Robert Pearce
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Pearce 2013-06-25 22:46:49 UTC
Using the "send hexadecimal" command causes a segmentation fault, especially if a blank sequence is entered, but usually regardless.

This is a simple buffer allocation error, combined with a failure to check for zero-length. It has been reported upstream, with notes of how to fix it, but is still open after 16 months. I have a patch that fixes it for me.

Reproducible: Always

Steps to Reproduce:
1.Run gtkterm
2.Select "Send hexadecimal"
3.Optionally type in some hex values
4.Hit enter
Actual Results:  
It segfaults

Expected Results:  
If you entered some data it should send it. If not it should do nothing or produce an informative status message
Comment 1 Robert Pearce 2013-06-25 22:47:45 UTC
Created attachment 351960 [details, diff]
Patch that fixes the bug
Comment 2 Pacho Ramos gentoo-dev 2016-08-25 15:57:58 UTC
please retry with 0.99.7_rc1

if still valid, please paste here the link to that bug report
Comment 3 Robert Pearce 2016-08-25 19:59:14 UTC
(In reply to Pacho Ramos from comment #2)
> please retry with 0.99.7_rc1
> 
> if still valid, please paste here the link to that bug report

Gosh, I'd almost forgotten about this.

It seems I've actually been using 0.99.7_rc1 for a month and it hasn't shown any problems. Looking at the code, the offending function got completely re-written at some point, probably along with their moving to a different host without closing the old SF project.

Thanks.