Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 474628 - dev-python/jedi test suite, tarball, phase upgrade,
Summary: dev-python/jedi test suite, tarball, phase upgrade,
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2013-06-24 18:09 UTC by Ian Delaney (RETIRED)
Modified: 2013-08-18 18:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (diffu.patch,1.31 KB, patch)
2013-06-24 18:09 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2013-06-24 18:09:21 UTC
Created attachment 351822 [details, diff]
patch

Point 1.  the tarball from pypi had done it again, left some content source out.
plse substitute 
SRC_URI="mirror://pypi/j/jedi/jedi-${MY_PV}.tar.gz"
with
SRC_URI="https://github.com/davidhalter/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"

Point 2. You can now run the test suite, like so;

test/test_regression.py .........................................................................................................................................................................
test/test_regression.py ...............................................................................................................................................................................
test/test_regression.py ...............................................................................
test/test_regression.py ..............................................

================== 778 passed in 45.04 seconds ===============================
...........

================== 778 passed in 45.63 seconds ===============================
...

================== 778 passed in 45.90 seconds ===============================
...

================== 778 passed in 46.89 seconds ===============================

granted it's a bit hard when half the test folder source is missing.
Comment 1 Mike Gilbert gentoo-dev 2013-06-24 18:18:57 UTC
Comment on attachment 351822 [details, diff]
patch

>+python_test() {
>+	PYTHONPATH="${PYTHONPATH}${S}"/test/ py.test test || die "Tests failed under ${EPYTHON}"
>+}

When appending to PYTHONPATH, make sure to include a colon; there is no guarantee that the existing PYTHONPATH value will end with a colon.

Example:

PYTHONPATH="${PYTHONPATH}:${S}/test/"

or, if you are being extra careful:

PYTHONPATH="${PYTHONPATH}${PYTHONPATH+:}${S}/test"
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2013-06-25 08:14:42 UTC
er yep, ack.  oh and
Point 3.  doc build for good measure
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2013-07-08 08:05:13 UTC
Can I commit as is?  If you've taken the path I skirted, that of awaiting upstream to top up the tarball, please say so and change to IN_PROGRESS.
timeout period 5 days, then python team will bump it.
Comment 4 Julian Ospald 2013-07-08 17:53:23 UTC
if there is no response within a week on the github issue, we can switch to the github tarballs

the attached patch does not incorporate #c1
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2013-07-13 15:30:16 UTC
righty
Comment 6 Julian Ospald 2013-07-13 15:31:10 UTC
(In reply to Ian Delaney from comment #5)
> righty

Please don't, see the github issue. It's being dealt with.
Comment 7 Mike Gilbert gentoo-dev 2013-07-16 04:00:40 UTC
I submitted a pull request upstream; hopefully that will grease the wheels a bit.
Comment 8 Julian Ospald 2013-07-16 04:03:26 UTC
cool
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2013-07-18 13:40:59 UTC
yes ditto.

@tkf @dbrgn When we're doing this, we should probably also add sith.py and .coveragerc, what do you think?

ugh
Comment 10 Julian Ospald 2013-07-27 21:50:41 UTC
upstream will include the fixes in the next release

if you care A LOT about it, then create a tarball with the missing files and push it to the gentoo mirrors, otherwise this is going to be RESOLVED UPSTREAM
Comment 11 Julian Ospald 2013-07-29 22:09:59 UTC
will be fixed on version bump
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2013-07-30 05:33:30 UTC
(In reply to Julian Ospald (hasufell) from comment #11)
> will be fixed on version bump

that works fine
Comment 13 Julian Ospald 2013-08-18 18:02:50 UTC
+*jedi-0.7.0 (18 Aug 2013)
+
+  18 Aug 2013; Julian Ospald <hasufell@gentoo.org> +jedi-0.7.0.ebuild:
+  version bump, fixes #474628