Bug 474458 – app-admin/hddtemp: add unit file

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Pacho Ramos 2013-06-23 07:57:57 UTC]

Attached ebuild.diff and unit file from systemd-love overlay. Thanks for committing it :)

Reproducible: Always

[Comment 1 Pacho Ramos 2013-06-23 07:58:15 UTC]

$ diff -u hddtemp-0.3_beta15-r22.ebuild hddtemp-0.3_beta15-r23.ebuild 
--- hddtemp-0.3_beta15-r22.ebuild	2012-10-27 14:14:08.000000000 +0200
+++ hddtemp-0.3_beta15-r23.ebuild	2013-06-23 09:57:00.000000000 +0200
@@ -4,7 +4,7 @@
 
 EAPI=4
 
-inherit eutils autotools
+inherit eutils autotools systemd
 
 MY_P=${P/_beta/-beta}
 DBV=20080531
@@ -62,6 +62,8 @@
 		echo -e "#!/bin/sh\n/usr/sbin/update-hddtemp.db" > "${T}"/hddtemp.cron
 		newexe "${T}"/hddtemp.cron update-hddtemp.db
 	fi
+
+	systemd_dounit "${FILESDIR}"/hddtemp.service
 }
 
 pkg_postinst() {

[Comment 2 Pacho Ramos 2013-06-23 07:58:53 UTC]

Created attachment 351704 [details]
hddtemp.service

[Comment 3 Pacho Ramos 2013-07-05 16:36:06 UTC]

I will commit in a week if nobody disagrees. Thanks

[Comment 4 Amadeusz Żołnowski (RETIRED) 2013-07-06 06:44:32 UTC]

I am going to work on reported bugs this weekend, so I'll commit it. If you'd like to do it now, you can go ahead (then please mark IN_PROGESS, first).

[Comment 5 Pacho Ramos 2013-07-06 06:59:48 UTC]

I will wait then as looks like there are other opened bugs that would deserve a revision bump and, then, better do all the changes in the same bump

Thanks

[Comment 6 Amadeusz Żołnowski (RETIRED) 2013-07-06 19:48:25 UTC]

I have modified unit file a bit. Please check if it is still correct and fix it if it is needed.

+*hddtemp-0.3_beta15-r23 (06 Jul 2013)
+*hddtemp-0.3_beta15-r6 (06 Jul 2013)
+
+  06 Jul 2013; Amadeusz Żołnowski <[e-mail]>
+  hddtemp-0.3_beta15-r3.ebuild, hddtemp-0.3_beta15-r5.ebuild,
+  +hddtemp-0.3_beta15-r6.ebuild, hddtemp-0.3_beta15-r22.ebuild,
+  +hddtemp-0.3_beta15-r23.ebuild, files/hddgentoo.db, +files/hddtemp.service:
+  Added systemd unit file (by Pacho Ramos <[e-mail]>)
+  - fixes bug #474458.
+
+  Removed 'nls' flag from IUSE, because it doesn't build if disabled
+  - fixes bug #457648.
+
+  Added WDC WD3200BEKT-75A25T0 and Hitachi HTS542512K9SA00 to hddgentoo.db
+  - fixes bug #470970 and bug #473686.
+