Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 473926 - Drop cvs expanded keywords from files in the portage tree.
Summary: Drop cvs expanded keywords from files in the portage tree.
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 12:10 UTC by Jan Matějka (RETIRED)
Modified: 2020-12-20 15:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Matějka (RETIRED) gentoo-dev 2013-06-20 12:10:54 UTC
Drop cvs expanded keywords from files in the portage tree.

AFAIK there are not used for anything usefull and make `repoman commit` do two commits in order to commit an ebuild change, which causes issues (see SeeAlso).

Reproducible: Always
Comment 1 Zac Medico gentoo-dev 2013-06-20 18:07:48 UTC
(In reply to Jan Matějka from comment #0)
> AFAIK there are not used for anything usefull

The only objection that I've heard was from Fabian Groffen since he's been using it in the gentoo-prefix sync script:

  http://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg55242.html
Comment 2 Fabian Groffen gentoo-dev 2013-06-20 20:04:06 UTC
yup, still do
Comment 3 Jan Matějka (RETIRED) gentoo-dev 2013-06-24 11:42:42 UTC
Then please fix your scripts not to depend on the keywords.
Comment 4 Fabian Groffen gentoo-dev 2013-06-24 12:22:49 UTC
(In reply to Jan Matějka from comment #3)
> Then please fix your scripts not to depend on the keywords.

I guess you have no clue what you're talking about.
Comment 5 Zac Medico gentoo-dev 2013-06-24 17:26:22 UTC
I guess the prefix script compares the $Header revision to the copy of ebuild that has been previously synced? Wouldn't it be possible to use digests or st_mtime instead?
Comment 6 Fabian Groffen gentoo-dev 2013-06-25 07:18:52 UTC
git doesn't track modification times (:()

Turning it the other way around: what is so important that we have to rush on removing keywords now, that I have to find all kinds of workarounds and hacks to keep some ebuilds synchronised for as long as we don't use a git main tree?  (AFAICT there is no such thing in the foreseeable future).

I'd love to not block you on this point, as much as I'd love not to have an overlay to keep in sync.  Unless I'm seriously impeding some other important and progressive changes, I kindly request to keep things as is.

Let me remind you that CVS commits are not atomic on global level, but per-file.  So even though you would avoid a "double commit", you're still not atomic, e.g. allowing a gap.
Comment 7 Christoph Junghans (RETIRED) gentoo-dev 2013-06-27 16:29:44 UTC
(In reply to Jan Matějka from comment #3)
> Then please fix your scripts not to depend on the keywords.
We just need to merge the remaining 130 packages from the prefix overlay back into gx86, then the keywords can go ;-) (see bug #315803 for the progress)
Comment 8 Jan Matějka (RETIRED) gentoo-dev 2013-06-27 19:19:36 UTC
(In reply to Fabian Groffen from comment #6)
> Let me remind you that CVS commits are not atomic on global level, but
> per-file.  So even though you would avoid a "double commit", you're still
> not atomic, e.g. allowing a gap.

There is problem specificaly with "double commit" as reported in bug #298605

> Turning it the other way around: what is so important that we have to rush
> on removing keywords now,

When I asked around why don't we just drop the keywords expansion, I got a reply like "one or two devs don't feel like it", so I wanted to get a rationale or at least to get this on record.
Comment 9 Jan Matějka (RETIRED) gentoo-dev 2013-06-27 19:36:11 UTC
The thing is, that people are coming up with unreliable shenanigans to solve bug #298605.

Well, besides mgorny whose solution seems quite clever, but still that solution adds code while this one would not (if not also remove some).
Comment 10 Fabian Groffen gentoo-dev 2020-12-20 15:42:14 UTC
This is broken for us for years, but we're coping with it.  In the current state of things, it's better this way, no need to consider anything for this.