This patch replaces the default "heart" heartbeat in LCDd with a nice, pusating Gentoo "G". It also states "Thanks for using Lcdproc and Gentoo" in stead of "Thanks for using Lcdproc and Linux" diff server/drivers/hd44780.c server/drivers/hd44780.c 712,717c712,713 < 1, 1, 1, 1, 1, // Empty Heart < 1, 0, 1, 0, 1, < 0, 0, 0, 0, 0, < 0, 0, 0, 0, 0, < 0, 0, 0, 0, 0, < 1, 0, 0, 0, 1, --- > 0, 0, 1, 0, 0, // Filled G > 0, 1, 1, 1, 0, 719a716,719 > 0, 0, 1, 1, 1, > 0, 1, 1, 1, 0, > 1, 1, 1, 1, 0, > 0, 1, 1, 0, 0, 723,728c723,724 < 1, 1, 1, 1, 1, // Filled Heart < 1, 0, 1, 0, 1, < 0, 1, 0, 1, 0, < 0, 1, 1, 1, 0, < 0, 1, 1, 1, 0, < 1, 0, 1, 0, 1, --- > 0, 1, 1, 1, 0, // Ali G > 1, 1, 0, 1, 1, 730a727,730 > 0, 1, 1, 1, 1, > 1, 1, 1, 1, 1, > 1, 1, 1, 1, 0, > 1, 1, 1, 1, 0, diff server/serverscreens.c server/serverscreens.c 182c182 < char *l20 = " LCDproc and Linux! "; --- > char *l20 = " LCDproc and Gentoo "; 190c190 < char *l16 = " LCDproc+Linux! "; --- > char *l16 = " LCDproc+Gentoo ";
The LCDproc team will drop official support for Gentoo if this patch is accepted. Regards, Rene
*** Bug 47261 has been marked as a duplicate of this bug. ***
To clarify things a bit. I don't want to be a complete moron here. As one of the upstream authors and the current lcdproc-stable maintainer I have picked up de-facto maintaining the LCDproc ebuild as soon as I installed Gentoo on one of my boxes and will continue to do so. FWIW I would like this to be marked WONTFIX and other LCDproc developers agree with that position. Look at it as something that will help with my motivation to continue my efforts trying to keep the Gentoo ebuild as high quality as possible. As far as the reasons to this are concerned, I just don't think modifying logos/splash screens/strings in the UI/etc. is the way one should deal with the original authors' work. I know that this is widely done in mainstream distributions but that doesn't mean that I have to be happy about it. Please note that this is totally unrelated to patches that fix bugs or add new functionality. Sorry for raising a fuss here, I haven't got much sleep recently. Regards, Rene
While it would be nice to be able to change lcdproc like this, it should be a runtime change, not something that needs to be compiled in - to allow all users to make the choice themselves (which is what Gentoo is about). I haven't used lcdproc for many years (I no longer have the hardware for it) - so I'm not certain if this is still applicable.
