Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 471828 - python.eclass: cp should no not rely on bash expansion
Summary: python.eclass: cp should no not rely on bash expansion
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 16:51 UTC by yegle
Modified: 2016-10-23 14:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description yegle 2013-05-30 16:51:19 UTC
This is related to bug 471760 https://bugs.gentoo.org/show_bug.cgi?id=471760

`grep '* ' python.eclass |grep '\<cp\>'`

There's three cp command relying on bash expansion, which may cause problem in prefix enviromnet (e.g. EPREFIX=/.some_dir_under_root_with_dot_prefix)

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2013-05-30 18:15:37 UTC
This should only be a problem when the glob is being applied to a directory which could possible begin with period, correct?

Could you please attach a build log from a package where this is causing a problem?
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2013-06-08 17:17:25 UTC
bug #471760#c2:
Just FYI, Same problem exists in gentoolkit

 * Call stack:
 *     ebuild.sh, line   93:  Called call-ebuildshell 'src_install'
 *   environment, line 1070:  Called src_install
 *   environment, line 5181:  Called distutils_src_install
 *   environment, line 1265:  Called python_merge_intermediate_installation_images '/.gentoo/var/tmp/portage/app-portage/gentoolkit-0.3.0.7-r2/temp/images'
 *   environment, line 4610:  Called die
 * The specific snippet of code:
 *               cp -fr --preserve=all --no-preserve=context "${intermediate_installation_images_directory}/${PYTHON_ABI}/"* "${D}" || die "Merging of intermediate installation image for Python ABI '${PYTHON_ABI} into installation image failed";

I guess, replacing "*" by "." would do the job.
Comment 3 Mike Gilbert gentoo-dev 2013-06-08 17:38:31 UTC
Copying Arfrever. Will replacing the * with a period work here?
Comment 4 Patrice Clement (RETIRED) gentoo-dev 2016-10-23 14:24:04 UTC
This eclass has been deprecated. See bug 459982.