471634 – app-misc/reptyr - respect CFLAGS

Bug 471634 - app-misc/reptyr - respect CFLAGS

Summary: app-misc/reptyr - respect CFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Tim Harder

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2013-05-28 22:50 UTC by Jeroen Roovers (RETIRED)
Modified:	2013-05-29 02:02 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeroen Roovers (RETIRED) gentoo-dev

2013-05-28 22:50:56 UTC

1) The Makefile appends -Werror and -g to CFLAGS.
2) The Makefile already adds -D_GNU_SOURCE (by appending it incorrectly to CFLAGS instead of CPPFLAGS).


--- reptyr-0.4.ebuild   4 Dec 2012 11:30:29 -0000       1.3
+++ reptyr-0.4.ebuild   28 May 2013 22:50:04 -0000
@@ -15,8 +15,12 @@
 KEYWORDS="amd64 ~arm x86 ~amd64-linux ~x86-linux"
 IUSE=""
 
+src_prepare() {
+       sed -i -e '/^override/d' Makefile || die
+}
+
 src_compile() {
-       append-cflags -D_GNU_SOURCE
+       append-cppflags -D_GNU_SOURCE
        emake CC=$(tc-getCC) CFLAGS="${CFLAGS}"
 }

Comment 1 Tim Harder gentoo-dev

2013-05-29 02:02:08 UTC

Fixed in CVS.