Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 471484 - FEATURES=bashrc
Summary: FEATURES=bashrc
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 21:44 UTC by Rick Farina (Zero_Chaos)
Modified: 2024-04-21 09:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Farina (Zero_Chaos) gentoo-dev 2013-05-27 21:44:34 UTC
from irc after me constantly crying about how slow it is to merge binpkgs:

17:35 < zmedico> Zero_Chaos: we could add a FEATURES setting to disable bash invocations for pkg_* phases that are not in DEFINED_PHASES
17:36 < Zero_Chaos> zmedico: is that even remotely safe?
17:36 < zmedico> Zero_Chaos: yes, except that any user hooks in bashrc won't be executed for those phases that are skipped
17:37 < Zero_Chaos> zmedico: can you explain to someone who is just a little dumber than you just explained that to?
17:39 < zmedico> Zero_Chaos: well, with existing behavior, /etc/portage/bashrc and the profile's profile.bashrc files are sourced/executed for every phase, even if they do nothing
17:39 < Zero_Chaos> zmedico: but if we are skipping the phase it also skips sourcing bashrc for that phase? that seems pretty safe.
17:39 < zmedico> Zero_Chaos: they can execute code in global scope, or define user phase hooks like pre_pkg_setup, post_pkg_setup, and so on
17:40 < Zero_Chaos> zmedico: so do you need a bug for FEATURES=make_faster_for_zero ?
17:40 < zmedico> Zero_Chaos: yeah, should be very safe generally.
17:40 < zmedico> Zero_Chaos: yes, please do.
17:40 < zmedico> FEATURES=bashrc
17:41 < zmedico> well
17:41 < zmedico> do you want to disable bashrc entirely?
17:41 < zmedico> or just when the phase is not in DEFINED_PHASES?
17:41 < zmedico> we could have separate settings
17:42 < zmedico> also, theres /etc/portage/env/$CATEGORY/...
17:42 < zmedico> those are a special kind of bashrc
17:42 < zmedico> could have a separate knob for those as well
17:42 < Zero_Chaos> I use the profile.bashrc, it's important that for the phases which run that it parses since it sets MAKEOPTS
17:42 < Zero_Chaos> well actually for my build system I override that so it's not *that* important
17:43 < zmedico> it might also make sense to vary these settings for binpkgs
17:43 < zmedico> since the bashrc stuff might matter less for them
17:44 < Zero_Chaos> zmedico: I'll leave that to you, and obviously I'm willing to test whatever you want.  My main complaint here is that binpkgs seem WAY slower than I feel they should be.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-16 01:10:46 UTC
I'm not convinced this is going to be what's slowing things down for you, but profiling results would help.

You can easily bail out early in /etc/portage/bashrc if you want, or just don't define one at all, right?