Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 470228 - app-emulation/virtualbox-guest-additions-4.1.24 with kernel 3.8 - fails to compile because of __devinitdata macro removal
Summary: app-emulation/virtualbox-guest-additions-4.1.24 with kernel 3.8 - fails to co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-18 06:23 UTC by K,Nakamiya
Modified: 2013-10-02 15:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
`emerge --info '=app-emulation/virtualbox-guest-additions-4.1.24'` (emerge-info.log,5.16 KB, text/plain)
2013-05-18 06:25 UTC, K,Nakamiya 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description K,Nakamiya 2013-05-18 06:23:08 UTC 
/var/tmp/portage/app-emulation/virtualbox-guest-additions-4.1.24/work/VirtualBox-4.1.24/src/VBox/Additions/common/VBoxGuest/VBoxGuest-linux.c:206:49: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'g_VBoxGuestPciId'
/var/tmp/portage/app-emulation/virtualbox-guest-additions-4.1.24/work/VirtualBox-4.1.24/src/VBox/Additions/common/VBoxGuest/VBoxGuest-linux.c:216:1: error: '__mod_pci_device_table' aliased to undefined symbol 'g_VBoxGuestPciId'
kmk: *** [/var/tmp/portage/app-emulation/virtualbox-guest-additions-4.1.24/work/VirtualBox-4.1.24/out/linux.amd64/release/obj/VBoxGuest/VBoxGuest-linux.o] Error 1

At VBoxGuest-linux.c:206 g_VBoxGuestPciId  use "__devinitdata" macro, but the macro is removed from linux-3.8 header.
Please refer to
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=54b956b903607f8f8878754dd4352da6a54a1da2

"__devinitdata" is not used other points in this application's source, so I think that the macro should be removed.

Reproducible: Always

Steps to Reproduce:
1. emerge '=sys-kernel/gentoo-sources-3.8.13'
2. cd /usr/src/linux-3.8.13-gentoo
3. make headers_install
4. emerge '=app-emulation/virtualbox-guest-additions-4.1.24'
Comment 1 K,Nakamiya 2013-05-18 06:25:33 UTC 
Created attachment 348586 [details]
`emerge --info '=app-emulation/virtualbox-guest-additions-4.1.24'`
Comment 2 Ben Kohler gentoo-dev 2013-10-02 15:37:36 UTC 
This was fixed upstream here:
https://www.virtualbox.org/changeset/44317/vbox/trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-linux.c

All versions in portage contain this fix, closing.