Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 470202 - dev-libs/geoip-1.4.8-r2 - update bug in /usr/sbin/geoipupdate.sh
Summary: dev-libs/geoip-1.4.8-r2 - update bug in /usr/sbin/geoipupdate.sh
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 20:41 UTC by Terra
Modified: 2013-05-18 14:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch for geoipupdate-r2.sh (file_470202.txt,403 bytes, patch)
2013-05-17 20:41 UTC, Terra 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Terra 2013-05-17 20:41:20 UTC 
Created attachment 348560 [details, diff]
patch for geoipupdate-r2.sh

There are a couple minor bugs in:  files/geoipupdate-r2.sh that was introduced via ChangeLog item:
  04 Feb 2013; Jeroen Roovers <jer@gentoo.org> files/geoipupdate-r2.sh,
  geoip-1.4.8-r3.ebuild, metadata.xml:
  Add USE=city, fix the update script so it only updates what is installed (bug
  #455340).

1) Invalid envariable name
2) fname not being suffixed with .dat

I have attached a patch that will fix this issue.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2013-05-18 14:26:09 UTC 
  29 Mar 2013; Christian Ruppert <idl0r@gentoo.org> files/geoipupdate-r2.sh:
  Another one..

  29 Mar 2013; Christian Ruppert <idl0r@gentoo.org> files/geoipupdate-r2.sh:
  Typo fixed

These were fixed already.