Bug 470166 – www-apps/tt-rss-1.7.9 - Failed Patch: 0002-Update-czech-translation.patch

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Callahan 2013-05-17 14:26:54 UTC]

Created attachment 348522 [details]
0002-Update-czech-translation.patch.out

Emerge fails patching source...

[Comment 1 Mike Callahan 2013-05-17 14:28:34 UTC]

Created attachment 348524 [details]
Build Log

[Comment 2 Mike Callahan 2013-05-17 14:30:30 UTC]

Created attachment 348526 [details]
emerge --info

[Comment 3 Tomáš Chvátal (RETIRED) 2013-05-17 16:43:16 UTC]

Thats really weird, seems to work on my end, could anyone else verify it works for them so we can pinpoint the issue?

[Comment 4 Roman Žilka 2013-05-17 18:24:44 UTC]

Created attachment 348552 [details]
emerge --info

All patches apply cleanly here.

[Comment 5 A Blamey 2013-05-17 18:34:22 UTC]

Created attachment 348554 [details]
Emerge info tt-rss

I see the exact same problem.

The failure is seen in the patch.out line 381:
'git binary diffs are not supported'

I tried emerging git and re-emerging patch and diffutils but it made no difference.

Do ebuilds normally support git binary diffs?
I can't say I've encountered them before in portage.

[Comment 6 Tomáš Chvátal (RETIRED) 2013-05-17 18:43:26 UTC]

What version of sys-devel/patch you guys have?

[Comment 7 A Blamey 2013-05-17 20:04:09 UTC]

I have the latest patch-2.7.1-r1, on ~x86.

[Comment 8 Roman Žilka 2013-05-17 20:12:13 UTC]

Can't emerge tt-rss with that version of patch either. patch-2.6.1 works.

[Comment 9 Tomáš Chvátal (RETIRED) 2013-05-17 20:29:34 UTC]

Mhm seems like bug in testing patch...

[Comment 10 Tomáš Chvátal (RETIRED) 2013-05-17 20:31:02 UTC]

@base: guys did I do something wrong with the patch itself or is the problem on the sys-devel/patch side?

[Comment 11 A Blamey 2013-05-17 20:51:35 UTC]

According to the release announcement for patch-2.7 at
http://savannah.gnu.org/forum/forum.php?forum_id=7361
the latest patch includes:

> Support for most features of the "diff --git" format, including renames and copies, permission changes, and symlink diffs. Binary diffs are not supported yet; patch will complain and skip them.

The explicit rejection of binary patches was added after 2.6.1 release.
http://git.savannah.gnu.org/cgit/patch.git/commit/?id=310f4c406aec408dcf5fc03d38ebe9f499088506

What is 2.6.1 actually doing with the binary patch you feed it?  Does it apply the patch correctly, or does it skip it and appear to succeeed?

What is policy on git binary patches?  I don't see mention in the dev handbook.

[Comment 12 Tomáš Chvátal (RETIRED) 2013-05-17 20:54:15 UTC]

I think I will just update the patch to be non-binary which seems to be easiest.

Will look to it tomorow.

[Comment 13 Tomáš Chvátal (RETIRED) 2013-05-20 09:20:44 UTC]

Fixed in cvs.

Enjoy and thanks for the report.