Bug 469954 – =media-gfx/fontforge-20110222-r1: fails to compile on a uclibc system

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Basile 2013-05-15 12:12:51 UTC]

fontforge-20110222 contains a useless declaration of an extern which leads to a compile time error on uclibc systems.  This is easily fixed by just removing it.  Unfortunately bumping to the next release (bug #429922) doesn't fix it, although upstream has fixed in in git/head, see the above url.

( cd Unicode ; make )
make[1]: Entering directory `/var/tmp/portage/media-gfx/fontforge-20110222-r1/work/fontforge-20110222/Unicode'
make[1]: `../libgunicode.la' is up to date.
make[1]: Leaving directory `/var/tmp/portage/media-gfx/fontforge-20110222-r1/work/fontforge-20110222/Unicode'
( cd gutils ; make )
make[1]: Entering directory `/var/tmp/portage/media-gfx/fontforge-20110222-r1/work/fontforge-20110222/gutils'
/bin/sh ../libtool --mode=compile x86_64-gentoo-linux-uclibc-gcc -O2 -pipe -I/usr/include/freetype2/ -I/usr/include/freetype2 -I/usr/include/libxml2/ -I/usr/include/cairo  -I/usr/include/python2.7 -I../inc -I../inc -I/usr/pkg/include -I/usr/pkg/include/giflib -Wmissing-prototypes -Wunused -Wimplicit -Wreturn-type -Wparentheses -Wformat -Wchar-subscripts  -DNOTHREADS -DHAVE_CONFIG_H -DLIBDIR='"/usr/lib"' -c gimagereadrgb.c
 x86_64-gentoo-linux-uclibc-gcc -O2 -pipe -I/usr/include/freetype2/ -I/usr/include/freetype2 -I/usr/include/libxml2/ -I/usr/include/cairo -I/usr/include/python2.7 -I../inc -I../inc -I/usr/pkg/include -I/usr/pkg/include/giflib -Wmissing-prototypes -Wunused -Wimplicit -Wreturn-type -Wparentheses -Wformat -Wchar-subscripts -DNOTHREADS -DHAVE_CONFIG_H -DLIBDIR=\"/usr/lib\" -c gimagereadrgb.c  -fPIC -DPIC -o .libs/gimagereadrgb.o
In file included from /usr/include/stdio.h:72:0,
                 from ../inc/basics.h:34,
                 from ../inc/gimage.h:29,
                 from gimagereadrgb.c:27:
gimagereadrgb.c: In function 'find_scanline':
gimagereadrgb.c:89:16: error: expected identifier or '(' before '__extension__'
     extern int fgetc(FILE *);
                ^
make[1]: *** [gimagereadrgb.lo] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-gfx/fontforge-20110222-r1/work/fontforge-20110222/gutils'
make: *** [libgutils] Error 2


Reproducible: Always

[Comment 1 Anthony Basile 2013-05-15 12:14:50 UTC]

Created attachment 348390 [details, diff]
Remove useless extern declaration

[Comment 2 Anthony Basile 2013-05-15 12:16:56 UTC]

You can just apply this after all the other patches in 20110222-r1, like this:

@@ -67,6 +67,7 @@
 src_prepare() {
 	epatch "${FILESDIR}/${P}-lxkbui.patch"
 	epatch "${FILESDIR}/${P}-libz.so-linkage.patch"
+	epatch "${FILESDIR}/${P}-remove-useless-extern.patch"
 	if use doc; then
 		chmod -x "${WORKDIR}"/html/*.html || die
 	fi


I should also add that this patch does not harm glibc systems.  I would still revbump.

[Comment 3 Anthony Basile 2013-05-28 15:47:28 UTC]

+  28 May 2013; Anthony G. Basile <[e-mail]>
+  +files/fontforge-20110222-remove-useless-extern.patch,
+  fontforge-20110222-r1.ebuild:
+  Remove useless extern, fixes compile on uclibc, bug #469954
+

Ack by yngwin in IRC