bump to Firefox 21.0
Just a little note here: it seems that something got broken regarding localization. Ebuild based on mozila-overlay produces firefox with general.useragent.locale en-US regardless of locale settings and firefox behaves as if the language pack wasn't installed. Also, intl.locale.matchOS, which was earlier true by default, is now false.
Note, that installing the language pack as if it were a normal extension makes it work. Makes me wonder if there would be a way for language packs to be installed by portage without being unpacked - just as user extensions now are (even if that's not that old change).
(In reply to comment #1) > Just a little note here: it seems that something got broken regarding > localization. > Ebuild based on mozila-overlay produces firefox with > general.useragent.locale en-US regardless of locale settings and firefox > behaves as if the language pack wasn't installed. > Also, intl.locale.matchOS, which was earlier true by default, is now false. The entire pref file is actually failing to be read, I will look into it tonight.
Installation fails here: >>> Install firefox-bin-21.0 into /var/tmp/portage/www-client/firefox-bin-21.0/image/ category www-client * ERROR: www-client/firefox-bin-21.0 failed (install phase): * !!! newins: /var/tmp/portage/www-client/firefox-bin-21.0/work/firefox/chrome/icons/default/default48.png does not exist Icons seem to have moved here: WORKDIR/firefox/browser/chrome/icons/default/default48.png
(In reply to comment #4) > Installation fails here: > > >>> Install firefox-bin-21.0 into /var/tmp/portage/www-client/firefox-bin-21.0/image/ category www-client > * ERROR: www-client/firefox-bin-21.0 failed (install phase): > * !!! newins: > /var/tmp/portage/www-client/firefox-bin-21.0/work/firefox/chrome/icons/ > default/default48.png does not exist > > > Icons seem to have moved here: > > > WORKDIR/firefox/browser/chrome/icons/default/default48.png With debug enabled this time: + newins /var/tmp/portage/www-client/firefox-bin-21.0/work/firefox/browser/chrome/icons/default/../../../icons/mozicon128.png firefox-bin.png + newicon /var/tmp/portage/www-client/firefox-bin-21.0/work/firefox/chrome/icons/default/default48.png firefox-bin-icon.png + _iconins newicon /var/tmp/portage/www-client/firefox-bin-21.0/work/firefox/chrome/icons/default/default48.png firefox-bin-icon.png ... Cut some stuff out, seems unrelated ... + [[ newicon == newicon ]] + newins /var/tmp/portage/www-client/firefox-bin-21.0/work/firefox/chrome/icons/default/default48.png firefox-bin-icon.png * ERROR
Created attachment 348402 [details] Fixed ebuild --- firefox-bin-21.0.ebuild.orig 2013-05-15 18:13:59.424866266 +0200 +++ firefox-bin-21.0.ebuild 2013-05-15 18:14:40.950864596 +0200 @@ -87,7 +87,7 @@ src_install() { insinto "/usr/share/icons/hicolor/128x128/apps" newins "${icon_path}/../../../icons/mozicon128.png" "${icon}.png" || die # Install a 48x48 icon into /usr/share/pixmaps for legacy DEs - newicon "${S}"/chrome/icons/default/default48.png ${PN}-icon.png + newicon "${icon_path}/default48.png" ${PN}-icon.png domenu "${FILESDIR}"/${PN}.desktop sed -i -e "s:@NAME@:${name}:" -e "s:@ICON@:${icon}:" \ "${ED}/usr/share/applications/${PN}.desktop" || die
(In reply to comment #3) > (In reply to comment #1) > > Just a little note here: it seems that something got broken regarding > > localization. > > Ebuild based on mozila-overlay produces firefox with > > general.useragent.locale en-US regardless of locale settings and firefox > > behaves as if the language pack wasn't installed. > > Also, intl.locale.matchOS, which was earlier true by default, is now false. > > The entire pref file is actually failing to be read, I will look into it > tonight. If you could update overlay and recompile would be appreciated. Soon as I have your feedback I will get it moved to tree.
Well, if the only change was patch tarball from 0.1 to 0.2, then it both did and didn't help. intl.locale.matchOS is true by default, just as it should be, but general.useragent.locale also is en-US and that's wrong. In fact, Add-ons Manager doesn't even show language pack as installed.
firefox-21 from mozilla overlay installs language extensions into /usr/lib/firefox/extensions/, while they shall be in /usr/lib/firefox/browser/extensions/ [1]. This is the reason why Add-on manager does not see them [1] http://mike.kaply.com/2013/05/13/more-major-changes-coming-in-firefox-21/
Regarding comment 9: That seems to help. At the same time simply placing langpack xpi, renamed to its description id, almost works: while value of general.useragent.locale doesn't change, firefox detects the extension as installed, just asks for confirmation at first run and after a restart it works. Don't know yet how it's getting registered by the current build, but figuring out this could potentially be used to simplify langpack/extensions install.
(In reply to comment #10) > Regarding comment 9: > That seems to help. At the same time simply placing langpack xpi, renamed to > its description id, almost works: while value of general.useragent.locale > doesn't change, firefox detects the extension as installed, just asks for > confirmation at first run and after a restart it works. > > Don't know yet how it's getting registered by the current build, but > figuring out this could potentially be used to simplify langpack/extensions > install. Other then linguas issues, all should be working, we will rework the eclass a bit for linguas support then get this all moved into the tree.
I am just testing to compile the overlay mozilla firefox-21 ebuild: USE=jemalloc gets jemalloc-1.0 from mozilla. But I have a system dev-libs/jemalloc-3.3.1 Should I file an extra bug? Would it be reasonable to have an extra use flag system-jemalloc
Uups, jemalloc is an issue of libreoffice, which I did compile at the time also, excuse me ... But I can confirm firefox-21 from mozilla overlay is running fine here since a few days.
Do we plan to skip this version? or we are waiting for 21.0.1?
--- a/eclass/mozextension.eclass +++ b/eclass/mozextension.eclass @@ -8,10 +8,22 @@ # @BLURB: Install extensions for use in mozilla products. -inherit eutils mozcoreconf-2 +inherit eutils DEPEND="app-arch/unzip" +mozversion_extension_location() { + case ${PN} in + firefox|firefox-bin) + if [[ $(get_version_component_range 1) -ge 21 ]] ; then + return 0 + fi + ;; + esac + + return 1 +} + xpi_unpack() { local xpi xpiname srcdir @@ -53,7 +65,7 @@ xpi_install() { # determine id for extension emid="$(sed -n -e '/install-manifest/,$ { /em:id/!d; s/.*[\">]\([^\"<>]*\)[\"<].*/\1/; p; q }' "${x}"/install.rdf)" \ || die "failed to determine extension id" - if $(mozversion_is_new_enough) ; then + if $(mozversion_extension_location) ; then insinto "${MOZILLA_FIVE_HOME}"/browser/extensions/${emid} else insinto "${MOZILLA_FIVE_HOME}"/extensions/${emid} If someone who has a linguas set could test this asap I will get this landed today and the bump to 21.0 will be able to happen.
Created attachment 349402 [details, diff] fix_extensions_installation.patch To easy in your testing use the patch, patch -p1. As I have said soon as I get the feedback I will get it all moved to tree.
running quite good here... emerge from overlay (the patch seems there already)... using linguas es_MX
Any new bugs please open create a new report. I have landed everything sorry for the delay.
