Bug 469856 – dev-python/python-memcached: migrate to distutils-r1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michael Palimaka (kensington) 2013-05-14 16:29:54 UTC]

Created attachment 348324 [details, diff]
python-memcached-1.48-distutils-r1.patch

Attached is a suggested patch.

[Comment 1 Michael Palimaka (kensington) 2013-05-14 16:49:57 UTC]

Created attachment 348326 [details, diff]
python-memcached-1.48-distutils-r1.patch

Slightly revised patch.

[Comment 2 Mike Gilbert 2013-05-14 17:29:38 UTC]

There is no need to override src_test and call python_foreach_impl manually; please define a python_test() function and run the test from that.

[Comment 3 Michael Palimaka (kensington) 2013-05-14 17:55:50 UTC]

Created attachment 348340 [details, diff]
python-memcached-1.48-distutils-r1.patch

Updated patch based on feedback.

[Comment 4 Ian Delaney (RETIRED) 2013-05-19 05:26:39 UTC]

looks good; couple of little ones;
${BUILD_DIR}/lib needs the usual "" -> "${BUILD_DIR}"/lib
popd > /dev/null is correct but in the flow, it's the last step of python_test, the next step will cd anyway, so it can be simply left out.
I ran it, the test phase works fine & fails horribly.
Anyone else before adding to portage?

[Comment 5 Michael Palimaka (kensington) 2013-05-22 09:06:11 UTC]

Created attachment 348884 [details, diff]
python-memcached-1.48-r1.patch

Revised patch to fix quoting and test issue - they cannot be run in parallel.

[Comment 6 Ian Delaney (RETIRED) 2013-05-22 14:46:32 UTC]

  22 May 2013; Ian Delaney <[e-mail]>
  +python-memcached-1.48-r1.ebuild:
  revbump, migrate -> distutils-r1, closes Bug #469856 by kensington