469842 – sys-apps/openrc-0.11.8: vlan config broken if ${IFACE} != ${IFVAR}

Bug 469842 - sys-apps/openrc-0.11.8: vlan config broken if ${IFACE} != ${IFVAR}

Summary: sys-apps/openrc-0.11.8: vlan config broken if ${IFACE} != ${IFVAR}

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	netifrc (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	netifrc Team

URL:	http://git.overlays.gentoo.org/gitweb...
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2013-05-14 14:47 UTC by Andreas Kinzler
Modified:	2013-08-24 01:20 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to use ${IFVAR} instead of ${IFACE} (openrc-vlan.patch,1.81 KB, patch) 2013-05-14 14:49 UTC, Andreas Kinzler	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kinzler 2013-05-14 14:47:03 UTC

/lib/rc/net/vlan.sh uses ${IFACE} instead of ${IFVAR} in eval instructions. This breaks all VLANs with ifaces like "eth.dsl" -> "eth.dsl.7"

See my patch.

Reproducible: Always

Comment 1 Andreas Kinzler 2013-05-14 14:49:00 UTC

Created attachment 348318 [details, diff]
patch to use ${IFVAR} instead of ${IFACE}

Comment 2 Andreas Kinzler 2013-05-14 14:49:55 UTC

URL points to the commit containing the bug

Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev

2013-08-20 20:21:26 UTC

I'm going to confirm this one ; ${IFVAR} is the version of ${IFACE} that can be used within a shell variable, and net/vlan.sh is explicitly trying to 'eval \$somevar_${IFACE}_whatever'.  Will get the patch into netifrc soon.

Comment 4 Robin Johnson archtester

2013-08-24 01:20:40 UTC

InGit.
I tweaked your config message as it looks like variable expansion bit you at some point.