Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469630 - media-video/smplayer: Add "skins" USE flag
Summary: media-video/smplayer: Add "skins" USE flag
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
Depends on: 469628
Blocks:
  Show dependency tree
 
Reported: 2013-05-12 23:08 UTC by Nikos Chantziaras
Modified: 2013-05-25 10:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Adds "skin" USE flag to all current smplayer ebuilds. (add_skins_use_flag.patch,2.04 KB, text/plain)
2013-05-12 23:09 UTC, Nikos Chantziaras
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2013-05-12 23:08:42 UTC
Since version 0.8.2, SMPlayer provides a new, skin-based interface. I submitted bug 469628 that adds an ebuild for the skins package. On the smplayer ebuild side, a new "skins" USE flag would control this. I am attaching a patch here, that adds that USE flag to all the smplayer ebuilds currently in portage (0.8.3, 0.8.4 and 0.8.4-r1).

The USE flag is not enabled by default. However, since version 0.8.5 of SMPlayer (bug 469368), the skinable GUI is made the default by upstream, so the ebuild for that version should most probably use "+skins" to reflect that default.

Since adding this USE flag depends on the existence of the smplayer-skins package, a blocker is needed in bug 469628.

Reproducible: Always
Comment 1 Nikos Chantziaras 2013-05-12 23:09:55 UTC
Created attachment 348118 [details]
Adds "skin" USE flag to all current smplayer ebuilds.
Comment 2 Denis M. (Phr33d0m) 2013-05-12 23:49:51 UTC
There's no need for two bugs for such requests, imo.
Comment 3 Ben de Groot (RETIRED) gentoo-dev 2013-05-25 06:02:59 UTC
We don't normally add useflags for such optional add-ons.
Comment 4 Nikos Chantziaras 2013-05-25 10:07:24 UTC
(In reply to comment #3)
> We don't normally add useflags for such optional add-ons.

It's not optional. It's the new upstream default. The "Skinable GUI" option in the SMPlayer preferences dialog will be grayed out otherwise, even though it should be the default.

You can read about it here:

http://smplayer.sourceforge.net/forum/viewtopic.php?f=3&t=6203

If the USE flag isn't to be added, then x11-themes/smplayer-skins should be put in RDEPEND unconditionally. I suggested the USE flag for users who don't want the new upstream default.

I thought that Gentoo policy was that ebuild defaults should reflect upstream defaults.