469608 – app-misc/golly should install icon

Bug 469608 - app-misc/golly should install icon

Summary: app-misc/golly should install icon

Status:	RESOLVED TEST-REQUEST

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Michael Weber (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-05-12 18:42 UTC by Samuel Bauer
Modified:	2013-05-16 16:17 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Samuel Bauer 2013-05-12 18:42:24 UTC

Installing golly is yet missing for the application icon.

Reproducible: Always




To fix it, just add:

>  src_install() {
>         emake docdir= DESTDIR="${D}" install
> +       newicon appicon.xpm ${PN}.xpm
>         dodoc README TODO
>  }

Comment 1 Michael Weber (RETIRED) gentoo-dev

2013-05-15 07:12:35 UTC

newicon is from eutils.eclass -> inherit eutils

I tried to convert to python*-r1 eclasses.

Please test and report success/failure. Thanks

+*golly-2.4-r1 (15 May 2013)
+
+  15 May 2013; Michael Weber <xmw@gentoo.org> +golly-2.4-r1.ebuild:
+  Add icon (thanks Samuel BAUER, bug 469608), python-single-r1 eclass.
+

Comment 2 Samuel Bauer 2013-05-16 16:17:51 UTC

I added the eutils eclass into the ebuild:

> -inherit eutils python toolchain-funcs wxwidgets
> +inherit python toolchain-funcs wxwidgets

then remerged golly successfully. I think eutils eclass was inherited from some other eclass already included in the ebuild, I'm aware one should avoid it, but ...

Test successful