Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469518 - =net-misc/minidlna-1.1.0-r1 - should be configured with --with-db-path=/var/lib/minidlna
Summary: =net-misc/minidlna-1.1.0-r1 - should be configured with --with-db-path=/var/l...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-12 01:20 UTC by BT
Modified: 2013-05-15 08:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2013-05-12 01:20:38 UTC
net-misc/minidlna-1.1.0-r1 is configured with '--with-db-path=/var/cache/minidlna' even though we use /var/lib/minidlna throughout the ebuild. This issue is really about consistency since setting the correct value in /etc/minidlna.conf will work.

I think we should also sed the correct value for db_dir in src_prepare just like we do for log_dir. The default is '/var/cache/minidlna'.
Comment 1 Michael Weber (RETIRED) gentoo-dev 2013-05-15 07:47:17 UTC
Should we stick with /var/lib/minidlna or use upstream's /var/cache/minidlna?
According to http://www.pathname.com/fhs/pub/fhs-2.3.html both seem ok.

Effects of moving:

-Existing installations have /var/lib/${PN} as user home in /etc/passwd,
but that should not have any effect.

-Upstream compliant dirs (less sed and dodir(?) statements in ebuild.

-Cache would be re-created (time consuming) and the removal of the old cache is subject to elog and manual user interaction. Are 1.0 and 1.1 cache files compatible?

- Stale cache dirs/files can lead to confused users, monitoring the wrong file while rescan'ing.

Opinions?

I add keywords after this issue is solved.

+*minidlna-1.1.0-r2 (15 May 2013)
+
+  15 May 2013; Michael Weber <xmw@gentoo.org> +minidlna-1.1.0-r2.ebuild,
+  -minidlna-1.0.25.ebuild, -minidlna-1.1.0-r1.ebuild, -minidlna-1.1.0.ebuild,
+  metadata.xml:
+  Stick with db_dir inside /var/lib (bug 469518), add IUSE netgear and readynas
+  (bug 469526), thanks BT
+
Comment 2 BT 2013-05-15 08:08:20 UTC
(In reply to comment #1)
I think we should stick with /var/lib/${PN} since we have already made the migration to this location. Moving again will just create more issues. I don't think it really matters if the location differs from upstream default since it can be changed in the configuration file anyway.
Comment 3 Michael Weber (RETIRED) gentoo-dev 2013-05-15 08:33:52 UTC
(In reply to comment #2)
> (In reply to comment #1)
> I think we should stick with /var/lib/${PN} since we have already made the
> migration to this location. Moving again will just create more issues.

Ok, thanks.

+  15 May 2013; Michael Weber <xmw@gentoo.org> minidlna-1.1.0-r2.ebuild:
+  Reestablish keywords
+