Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469160 - x11-drivers/ati-drivers-13.4 - .../work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:1546:5: error: incompatible types when returning type ‘kuid_t’ but ‘KCL_TYPE_Uid’ was expected
Summary: x11-drivers/ati-drivers-13.4 - .../work/common/lib/modules/fglrx/build_mod/2....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: emil karlson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 11:36 UTC by Dennis Schridde
Modified: 2013-05-20 17:44 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,6.28 KB, text/plain)
2013-05-09 11:36 UTC, Dennis Schridde 		Details
config-3.9.0-gentoo (config-3.9.0-gentoo,78.94 KB, text/plain)
2013-05-09 11:37 UTC, Dennis Schridde 		Details
emerge --info (emerge.info,5.70 KB, text/plain)
2013-05-09 11:38 UTC, Dennis Schridde 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2013-05-09 11:36:33 UTC 
/var/tmp/portage/x11-drivers/ati-drivers-13.4/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function ‘KCL_GetEffectiveUid’:
/var/tmp/portage/x11-drivers/ati-drivers-13.4/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:1546:5: error: incompatible types when returning type ‘kuid_t’ but ‘KCL_TYPE_Uid’ was expected

There are also some warnings, but I assume that's expected by the authors:
/var/tmp/portage/x11-drivers/ati-drivers-13.4/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function ‘KCL_EFI_IS_ENABLED’:
/var/tmp/portage/x11-drivers/ati-drivers-13.4/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:3091:5: warning: return makes integer from pointer without a cast [enabled by default]
/var/tmp/portage/x11-drivers/ati-drivers-13.4/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function ‘KCL_GetEffectiveUid’:
/var/tmp/portage/x11-drivers/ati-drivers-13.4/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:1550:1: warning: control reaches end of non-void function [-Wreturn-type]

Reproducible: Always
Comment 1 Dennis Schridde 2013-05-09 11:36:55 UTC 
Created attachment 347820 [details]
build.log
Comment 2 Dennis Schridde 2013-05-09 11:37:22 UTC 
Created attachment 347824 [details]
config-3.9.0-gentoo
Comment 3 Dennis Schridde 2013-05-09 11:38:12 UTC 
Created attachment 347828 [details]
emerge --info
Comment 4 Dennis Schridde 2013-05-09 12:00:05 UTC 
Vague guess: CONFIG_USER_NS might be to blame.
Comment 5 emil karlson 2013-05-11 02:16:20 UTC 
Can you try ati-drivers-13.4 from x11 overlay, should be fixed there.
Comment 6 Dennis Schridde 2013-05-11 13:16:43 UTC 
(In reply to comment #5)
> Can you try ati-drivers-13.4 from x11 overlay, should be fixed there.

Patch works, but I wonder whether UIDGID_CONVERTED or UIDGID_STRICT_TYPE_CHECKS should be tested against, instead of the kernel version. (I do not have any idea about the kernel internals - just wondering, because I read about one of these config values in an article.)
Comment 7 emil karlson 2013-05-11 14:14:56 UTC 
the casting function seems to be explicitly defined in both preprocessor conditional branches, so I assume this is the way to use it.

Thanks for the report and testing.
Comment 8 Charo del Genio 2013-05-18 17:23:47 UTC 
I can confirm this. Also, I checked, as suggested in Comment 6, and the bug is triggered by CONFIG_UIDGID_STRICT_TYPE_CHECKS. To avoid the bug, one can just set
CONFIG_UIDGID_CONVERTED=y
# CONFIG_UIDGID_STRICT_TYPE_CHECKS is not set
in .config.
Comment 9 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-05-20 17:44:45 UTC 
Changes were imported to portage.