media-sound/xmms-1.2.10-r2 breaks the CornerXMMS gdesklet -- or depending on how you look at it, CornerXMMS does not work with this version of XMMS. instead of the song/stream/track title scrolling, you get some numbers scrolling. i downgraded to -r1 nad the CornerXMMS gdesklet works again.
odd... only about 10 lines of code changed between these versions... can you try commenting out the recode patch in the xmms ebuild to see if that fixes your problem?
It works with these changes. # Patch for mpg123 to convert Japanese character code of MP3 tag info # the Japanese patch and the Russian one overlap, so its one or the other if use cjk; then epatch ${PATCHDIR}/${P}-mpg123j.patch # else # # add recode patch http://sourceforge.net/projects/rusxmms/ # epatch ${PATCHDIR}/${P}-recode-csa27.3.patch fi
Created attachment 28806 [details, diff] xmms-1.2.10-recode-csa27.3.revertToOld.patch revert recode patch to 1.2.10-r1 version...
can youu save that patch and apply it as below (I assumed you saved it to /tmp) # Patch for mpg123 to convert Japanese character code of MP3 tag info # the Japanese patch and the Russian one overlap, so its one or the other if use cjk; then epatch ${PATCHDIR}/${P}-mpg123j.patch else # add recode patch http://sourceforge.net/projects/rusxmms/ epatch ${PATCHDIR}/${P}-recode-csa27.3.patch epatch /tmp/xmms-1.2.10-recode-csa27.3.revertToOld.patch fi Loet me know if that fixes the problem, and if so, could you try to narrow down what in that patch causes the problem... if you're not comfortable with messing with source like that, I can try to figure it out, but I don't use cornerxmms so it will take more time...
That fixed the problem. I'm not really a programmer but I'll take a look and see if I can see what is messing it up.
btw... dunno if you know this, but it's a huge timesaver you don't need to remcompile all of xmms every time during debugging... $ cd /usr/portage/media-sound/xmms $ ebuild xmms-1.2.10-r2.ebuild merge this leaves the code in portage tmp folder, so you can goto it: $ pushd /usr/tmp/portage/xmms-1.2.10-r2/work/xmms-1.2.10-r2 now remove the patch I posted here (this assumes that the ebuild you used was the one with the patch... if not, skip): $ patch -p1 -R < /tmp/xmms-1.2.10-recode-csa27.3.revertToOld.patch then copy that patch somewhere, edit it to remove the fixes to the last two files (the bottom two chunks where it starts out with ++++ and ---- lines) and apply that: $ patch -p1 < /tmp/xmms-1.2.10-recode-csa27.3.revertToOld.modified.patch now go back and try merging that: $ popd $ rm /usr/tmp/portage/xmms-1.2.10-r2/.compiled (this forces the updated code to be recompiled, but it doesn't unpack everything again and reapply the patches... assuming youu don't update the ebuild). $ ebuild xmms-1.2.10-r2.ebuild merge then go and revert that modified patch (with the -R like you did above) and you can keep modifying it to zoom in on the problem code.
I have tracked it down this far. I'll start eliminating parts of this to see if I can find out exactly what it is. diff -Naur xmms-1.2.10.dtd.id3v2.recode/xmms/playlist.c xmms-1.2.10.dtd.id3v2.recode.old/xmms/playlist.c --- xmms-1.2.10.dtd.id3v2.recode/xmms/playlist.c 2004-04-04 16:45:12.000000000 -0700 +++ xmms-1.2.10.dtd.id3v2.recode.old/xmms/playlist.c 2004-04-06 14:38:32.000000000 -0700 @@ -1402,9 +1402,9 @@ filename = g_strdup(entry->filename); - if (entry->title == NULL || entry->length == -1) + if (entry->title == NULL && entry->length == -1) { - if (playlist_get_info_entry(entry)&&(entry->title)) { + if (playlist_get_info_entry(entry)) { title = xmms_charset_recode_id3(entry->title,0,NULL); if (!title) title = g_strdup(entry->title);
This is the part of the revert patch that fixes the bug, the rest of the patch can be left out. - if (entry->title == NULL || entry->length == -1) + if (entry->title == NULL && entry->length == -1) If it is compiled with the || instead of the && it breaks the song title display in the CornerXMMS Desklet.
odd... that little snippet of code looks right to me... i wonder why it's behaving like that... I created a bug upstream so they can look at it: http://sourceforge.net/tracker/index.php?func=detail&aid=931146&group_id=65796&atid=512282
applying the patch after the recode patch fixed streaming titles in shaded mode for me
Confirming SpanKY's comment. The attached patch fixed it.
this is fixed in -r3
