Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468822 - net-voip/sflphone-1.2.2 - add support for KDE client
Summary: net-voip/sflphone-1.2.2 - add support for KDE client
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Jean-Noël Rivasseau (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-05-07 07:47 UTC by Balazs Nemeth
Modified: 2013-08-03 16:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sflphone-1.2.2-kde-client-support.patch (sflphone-1.2.2-kde-client-support.patch,1.75 KB, patch)
2013-05-07 07:48 UTC, Balazs Nemeth
Details | Diff
sflphone-1.2.2-fix-qttest-path.patch (sflphone-1.2.2-fix-qttest-path.patch,721 bytes, patch)
2013-05-07 07:49 UTC, Balazs Nemeth
Details | Diff
sflphone-1.2.2-disable-tests.patch (sflphone-1.2.2-disable-tests.patch,571 bytes, patch)
2013-05-07 07:49 UTC, Balazs Nemeth
Details | Diff
sflphone-1.2.2-kde-client-support-2.patch (sflphone-1.2.2-kde-client-support-2.patch,1.97 KB, patch)
2013-05-08 05:52 UTC, Balazs Nemeth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Nemeth 2013-05-07 07:47:47 UTC
I have added support for the KDE client of sflphone to its latest ebuild (1.2.2).
I have tested it on KDE 4.10.1 on x86_64. Both the gnome and the kde client compiles for me. Though there are some QA warnings which should be taken care of by someone who is more familiar with ebuilds than me.
The ebuild also requires to patches to be applied, I am attaching those too.

I dropped the idea of having a separate ebuild for the client as imho it would increases the maintenance overhead.
Reference: https://bugs.gentoo.org/show_bug.cgi?id=416999#c26

Reproducible: Always
Comment 1 Balazs Nemeth 2013-05-07 07:48:30 UTC
Created attachment 347568 [details, diff]
sflphone-1.2.2-kde-client-support.patch

patch against sflphone-1.2.2.ebuild
Comment 2 Balazs Nemeth 2013-05-07 07:49:01 UTC
Created attachment 347570 [details, diff]
sflphone-1.2.2-fix-qttest-path.patch

fix build time issues 1/2
Comment 3 Balazs Nemeth 2013-05-07 07:49:34 UTC
Created attachment 347572 [details, diff]
sflphone-1.2.2-disable-tests.patch

fix build time issues 2/2
Comment 4 Balazs Nemeth 2013-05-08 05:52:51 UTC
Created attachment 347702 [details, diff]
sflphone-1.2.2-kde-client-support-2.patch

Forgot to add the relevant KDE dependencies, now here they are..
Comment 5 Lukas Zavodny 2013-06-16 09:46:56 UTC
Any chance to see this in tree?
Comment 6 Jean-Noël Rivasseau (RETIRED) gentoo-dev 2013-08-03 16:14:40 UTC
KDE support was added to 1.2.3 (where it seems the build patches are not needed). Thanks for the work Balazs.