Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468676 - dev-lang/luajit-2.0.0_beta8_p1 and later break pkg-config file
Summary: dev-lang/luajit-2.0.0_beta8_p1 and later break pkg-config file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Rafael Martins (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-05 16:16 UTC by Julian Ospald
Modified: 2013-05-28 01:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
luajit-2.0.1.ebuild (luajit-2.0.1.ebuild,3.47 KB, text/plain)
2013-05-27 08:02 UTC, Vadim A. Misbakh-Soloviov (mva) (RETIRED)
Details
luajit-2.0.1.ebuild (luajit-2.0.1.ebuild,3.68 KB, text/plain)
2013-05-27 18:38 UTC, Vadim A. Misbakh-Soloviov (mva) (RETIRED)
Details
luajit-2.0.1.ebuild (luajit-2.0.1.ebuild,3.71 KB, text/plain)
2013-05-27 20:31 UTC, Vadim A. Misbakh-Soloviov (mva) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-05-05 16:16:08 UTC
# pkg-config --libs luajit-2.0
-lluajit-jit-5.1


but the libs are named as follows:
/usr/lib64/libluajit-2.0.a
/usr/lib64/libluajit-2.0.so
/usr/lib64/libluajit-2.0.so.0

One of it is wrong, I don't really know how you intended to do this in the first place, but this mismatch will break every build system that uses "pkg-config --libs luajit-2.0".

This is true for:
dev-lang/luajit-2.0.0_beta8_p1
dev-lang/luajit-2.0.0_beta10
dev-lang/luajit-2.0.0
Comment 1 Julian Ospald 2013-05-05 16:17:49 UTC
maybe this was intended to be used with a virtual package and some kind of eselect?
Comment 2 Dennis Schridde 2013-05-16 11:19:49 UTC
I just ran into the same issue.
Comment 3 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-26 17:16:41 UTC
Temporary, use ebuilds from lua overlay.
I'll try to propose them in gentoo after 2.0.2 release
Comment 4 Julian Ospald 2013-05-26 17:17:56 UTC
(In reply to Vadim A. Misbakh-Soloviov (mva) from comment #3)
> Temporary, use ebuilds from lua overlay.
> I'll try to propose them in gentoo after 2.0.2 release

Pointing users to overlays is suboptimal. If you can provide a patch, please attach it here.
Comment 5 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 07:50:00 UTC
(In reply to Julian Ospald (hasufell) from comment #4)
> Pointing users to overlays is suboptimal. If you can provide a patch, please
> attach it here.

Not that I have a patch. Just LJ-2.0.1 (and upcoming 2.0.2, and also 2.1.9999), installed by my ebuilds from lua-overlay, works fine. So, I only can attach ebuild 2.0.1 for now (and ask mabi to don't forget to bump it to 2.0.2 in few days).
Comment 6 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 08:02:00 UTC
Created attachment 349328 [details]
luajit-2.0.1.ebuild

Actually, it PDEPENDs on dev-lua/iluajit (to have normally-working interactive console, since by default it is almost unusable) and virtual/lua[luajit] (since I hardly working on luajit-compatibility of many Lua-related packages).

So, I suggest you [or mabi] to at least take dev-lua/iluajit to the tree.
Comment 7 Rafael Martins (RETIRED) gentoo-dev 2013-05-27 12:17:13 UTC
(In reply to Julian Ospald (hasufell) from comment #1)
> maybe this was intended to be used with a virtual package and some kind of
> eselect?

we aren't going to add an eselect module for lua any time soon.
Comment 8 Rafael Martins (RETIRED) gentoo-dev 2013-05-27 12:19:09 UTC
(In reply to Vadim A. Misbakh-Soloviov (mva) from comment #5)
> (In reply to Julian Ospald (hasufell) from comment #4)
> > Pointing users to overlays is suboptimal. If you can provide a patch, please
> > attach it here.
> 
> Not that I have a patch. Just LJ-2.0.1 (and upcoming 2.0.2, and also
> 2.1.9999), installed by my ebuilds from lua-overlay, works fine. So, I only
> can attach ebuild 2.0.1 for now (and ask mabi to don't forget to bump it to
> 2.0.2 in few days).

don't know why you're trying to push mabi into this issue. he has nothing to do with luajit. not that I don't want him helping, but he isn't luajit maintainer at this time.
Comment 9 Rafael Martins (RETIRED) gentoo-dev 2013-05-27 12:22:13 UTC
(In reply to Vadim A. Misbakh-Soloviov (mva) from comment #6)
> Created attachment 349328 [details]
> luajit-2.0.1.ebuild
> 
> Actually, it PDEPENDs on dev-lua/iluajit (to have normally-working
> interactive console, since by default it is almost unusable) and
> virtual/lua[luajit] (since I hardly working on luajit-compatibility of many
> Lua-related packages).
> 
> So, I suggest you [or mabi] to at least take dev-lua/iluajit to the tree.

your 'interactive' use flag in luajit is totally wrong. you shouldn't use USE flags just to force a dep, and this is even worse with a pdep.

the iluajit project is interesting, but it DOES NOT belongs to dev-lang/luajit :(
Comment 10 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 17:45:20 UTC
(In reply to Rafael G. Martins from comment #8)
> don't know why you're trying to push mabi into this issue. he has nothing to
> do with luajit. not that I don't want him helping, but he isn't luajit
> maintainer at this time.

I just (okay, by mistake) mentioned mabi as a person, I thought as lua-herd and a person I discussed on luajit few moments earlier. Okay, I see, that he's not luajit maintainer already, so, hasufell, s/mabi/rafaelmartins/ ;).

(In reply to Rafael G. Martins from comment #9)
> your 'interactive' use flag in luajit is totally wrong. you shouldn't use
> USE flags just to force a dep, and this is even worse with a pdep.
> the iluajit project is interesting, but it DOES NOT belongs to
> dev-lang/luajit :(

It is just for user convenience. It is useflags behaviour in my mind: to let user enable or disable features, that he migh want (interactive shell in luajit) or not (systemd support in some packages). Including providing PDEPENDs (at least, in my mind). Of course, I could be wrong. Any way, I was inspired by "emacs" useflag, that doing all the same. Only difference is that I added "+" to "interactive" (since I suggest it to user, since it was a part of making luajit possible to fully replace C lua), while 'emacs' has no "+".

Am I wrong? Should I delete both emacs and interactive flags?
Comment 11 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 17:58:48 UTC
(In reply to Vadim A. Misbakh-Soloviov (mva) from comment #10)
> Am I wrong? Should I delete both emacs and interactive flags?

But okay, ragarding to devmanual, I'm wrong, so, okay, I'll fix it all.

But anyway:
$ grep PDEP /usr/portage/dev-lang/lua/lua-5.2.1.ebuild
PDEPEND="emacs? ( app-emacs/lua-mode )"
Comment 12 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 18:38:00 UTC
Created attachment 349374 [details]
luajit-2.0.1.ebuild

This is ebuild, fixed in manner, rafaelmartins mention (to not use USE-flags to PDEPEND something).
While it is still pdepends on virtual/lua[luajit].
Comment 13 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 19:01:32 UTC
Uhm. Sorry, I found one bug, I added when improving that ebuild, and I also forgot to make some more improvements. I'll add once more fixed ebuild in some time.
Comment 14 Vadim A. Misbakh-Soloviov (mva) (RETIRED) gentoo-dev 2013-05-27 20:31:58 UTC
Created attachment 349394 [details]
luajit-2.0.1.ebuild

Finally fixed (I hope).
Still suggest to discuss adding virtual/lua (with:
RDEPEND="
        !luajit? ( dev-lang/lua )
        luajit? ( dev-lang/luajit:2 )
"
to the tree.

Also, ebuild contains reference to hotfix1 patch from upstream's download page.
Comment 15 Rafael Martins (RETIRED) gentoo-dev 2013-05-27 20:32:19 UTC
(In reply to Vadim A. Misbakh-Soloviov (mva) from comment #12)
> Created attachment 349374 [details]
> luajit-2.0.1.ebuild
> 
> This is ebuild, fixed in manner, rafaelmartins mention (to not use USE-flags
> to PDEPEND something).
> While it is still pdepends on virtual/lua[luajit].

I'm not going to accept any ebuild that differs that much of the ebuild that is in tree. Please stop trying to introduce new things on luajit ebuilds.
Comment 16 Rafael Martins (RETIRED) gentoo-dev 2013-05-27 20:42:26 UTC
(In reply to Rafael G. Martins from comment #15)
> (In reply to Vadim A. Misbakh-Soloviov (mva) from comment #12)
> > Created attachment 349374 [details]
> > luajit-2.0.1.ebuild
> > 
> > This is ebuild, fixed in manner, rafaelmartins mention (to not use USE-flags
> > to PDEPEND something).
> > While it is still pdepends on virtual/lua[luajit].
> 
> I'm not going to accept any ebuild that differs that much of the ebuild that
> is in tree. Please stop trying to introduce new things on luajit ebuilds.

and btw, as hasufell just remembered me on IRC, our >2.0.0_beta7 ebuilds are hardmasked, because they include experimental patches, that were rejected by upstream, and we may remove them any time soon. please base your ebuilds on 2.0.0_beta7, if you want to get it committed in tree unmasked.

thanks.
Comment 17 Rafael Martins (RETIRED) gentoo-dev 2013-05-28 01:06:23 UTC
fixed in luajit-2.0.1_p1