Bug 468184 – media-libs/libogg - does not respect --docdir option

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Karl Lindén 2013-05-01 18:58:17 UTC]

Created attachment 347062 [details, diff]
The patch to honour docdir

Was: 464486

As the title says. The --docdir option is not honoured, i.e the docs will always install into /usr/share/doc/libogg-1.3.0. If the ebuild is revbumped (maybe due to bug 464486) the docs will be installed into the wrong directory.

I'm attaching a patch that makes the build system respect --docdir.

The bug has been reported upstream. Please see [1].

[1] https://trac.xiph.org/ticket/1758

[Comment 1 Samuli Suominen (RETIRED) 2013-05-01 19:55:12 UTC]

Thanks for submitting it upstream, that helps a lot. Temporary docdir= added to the ebuild in emake install (to avoid eautoreconf, autotools maintainer mode, and such)

[Comment 2 Samuli Suominen (RETIRED) 2013-05-01 20:30:22 UTC]

(In reply to comment #0)
> Created attachment 347062 [details, diff] [details, diff]
> The patch to honour docdir
> 
> Was: 464486
> 
> As the title says. The --docdir option is not honoured, i.e the docs will
> always install into /usr/share/doc/libogg-1.3.0. If the ebuild is revbumped
> (maybe due to bug 464486) the docs will be installed into the wrong
> directory.
> 
> I'm attaching a patch that makes the build system respect --docdir.
> 
> The bug has been reported upstream. Please see [1].
> 
> [1] https://trac.xiph.org/ticket/1758

I see now it was reported ages ago.

./configure --help | grep docdir says:

--docdir=DIR documentation root [DATAROOTDIR/doc/PACKAGE]

But upstream wants it in PACKAGE-VERSION, but that patch removes that -VERSION when --docdir is not passed (used outside from portage) and I don't think that is desired.

(and thanks)

[Comment 3 Karl Lindén 2013-05-01 20:50:11 UTC]

(In reply to comment #2)
> (In reply to comment #0)
> > Created attachment 347062 [details, diff] [details, diff] [details, diff]
> > The patch to honour docdir
> > 
> > Was: 464486
> > 
> > As the title says. The --docdir option is not honoured, i.e the docs will
> > always install into /usr/share/doc/libogg-1.3.0. If the ebuild is revbumped
> > (maybe due to bug 464486) the docs will be installed into the wrong
> > directory.
> > 
> > I'm attaching a patch that makes the build system respect --docdir.
> > 
> > The bug has been reported upstream. Please see [1].
> > 
> > [1] https://trac.xiph.org/ticket/1758
> 
> I see now it was reported ages ago.
> 
> ./configure --help | grep docdir says:
> 
> --docdir=DIR documentation root [DATAROOTDIR/doc/PACKAGE]
> 
> But upstream wants it in PACKAGE-VERSION, but that patch removes that
> -VERSION when --docdir is not passed (used outside from portage) and I don't
> think that is desired.
> 
> (and thanks)

You're right. What might be the reason behind it? Is there a way to set a default value somewhere so that --docdir could respected without the loss of previous default?