Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468092 - multilib-minimal.eclass: does not handle global DOCS properly
Summary: multilib-minimal.eclass: does not handle global DOCS properly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-01 08:12 UTC by Michał Górny
Modified: 2013-05-04 20:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-01 08:12:37 UTC
When an ebuild declares DOCS globally, default multilib_src_install tries to install them from the wrong directory. As a result, build process fails.

As a work-around, I may install docs manually in src_install() / multilib_src_install_all(), but that ain't really friendly.
Comment 1 Julian Ospald 2013-05-01 11:20:13 UTC
you can use

DOCS=( "${S}"/README.txt )


otherwise I'd do something like this:
multilib-minimal_src_install() {
[...]
    else
        DOCS="" default_src_install
    fi
[...]

    <copy paste of EAPI-doc install like autotools-utils does>
}
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2013-05-01 19:38:35 UTC
(In reply to comment #1)
> you can use
> 
> DOCS=( "${S}"/README.txt )
Ok, but not nice as most other eclasses support it without ${S}.
> 

> otherwise I'd do something like this:
> multilib-minimal_src_install() {
> [...]
>     else
>         DOCS="" default_src_install
>     fi
> [...]
> 
>     <copy paste of EAPI-doc install like autotools-utils does>
> }
Can you please add that hack to multilib-minimal.eclass?
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-01 20:30:05 UTC
Maybe inline 'emake DESTDIR=${D} install' instead? That should be less hackish, with the same net result.
Comment 4 Julian Ospald 2013-05-04 20:07:24 UTC
I tested all consumers and it seems to work. Yell at me, if not.

+  04 May 2013; Julian Ospald <hasufell@gentoo.org> multilib-minimal.eclass:
+  improve handling of DOCS variable wrt #468092