Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 467916 - kernel-2.eclass runs dodoc with empty argument list
Summary: kernel-2.eclass runs dodoc with empty argument list
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Miscellaneous
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 20:53 UTC by Alexandros Diamantidis
Modified: 2013-04-29 22:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
proposed patch to eclass/kernel-2.eclass (kernel-2.patch,299 bytes, patch)
2013-04-29 20:55 UTC, Alexandros Diamantidis 		Details | Diff
kernel-2.UNIPATCH_DOCS.patch (file_467916.txt,1.97 KB, text/plain)
2013-04-29 22:14 UTC, Tom Wijsman (TomWij) (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandros Diamantidis 2013-04-29 20:53:17 UTC 
While emerging sys-kernel/vanilla-sources-3.9.0 with paludis, I got the following error:

!!! ERROR in sys-kernel/vanilla-sources-3.9.0::gentoo:
!!! In /usr/libexec/paludis/utils/dodoc at line 41
!!! at least one argument needed

I think the problem is in kernel-2.eclass which contains the following:

        if [[ -z ${UNIPATCH_DOCS} ]] ; then
                dodoc ${UNIPATCH_DOCS}
        fi

If I'm not mistaken, this runs "dodoc" when UNIPATCH_DOCS is empty, while it should run when it's non-empty. Changing the -z to -n lets the emerge finish without errors.

Reproducible: Always
Comment 1 Alexandros Diamantidis 2013-04-29 20:55:30 UTC 
Created attachment 346930 [details, diff]
proposed patch to eclass/kernel-2.eclass
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-29 22:14:34 UTC 
Created attachment 346934 [details]
kernel-2.UNIPATCH_DOCS.patch

Patch as applied.
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-29 22:16:03 UTC 
gentoo-x86: tomwij eclass: Corrected UNIPATCH_DOCS functionality, a mistake slipped through testing and review, fixes bug #467916 reported by Alexandros Diamantidis.

/var/cvsroot/gentoo-x86/eclass/ChangeLog,v  <--  ChangeLog
new revision: 1.804; previous revision: 1.803
/var/cvsroot/gentoo-x86/eclass/kernel-2.eclass,v  <--  kernel-2.eclass
new revision: 1.284; previous revision: 1.283